Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent escaping in the exclude files #23

Open
bgolding355 opened this issue Aug 9, 2022 · 0 comments
Open

Inconsistent escaping in the exclude files #23

bgolding355 opened this issue Aug 9, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@bgolding355
Copy link
Contributor

The problem

The characters " and ' need to be escaped in the exclude files. Given that these are not special characters in Regex there is no reason why a user should need to do this

The solution

Not escaping " and ' should work

Example

Lets say that I have a file that looks like this:

password=123259807534
password2="4401259804330"

And none of these are actually secrets. To solve this, I might want to exclude these lines with something like:

password\d?="?\d+"?

But this will not work. A user will instead need to do:

password\d?=\"?\d+\"?

Which is not at all intuitive.

@bgolding355 bgolding355 added the bug Something isn't working label Aug 9, 2022
@jsoref jsoref changed the title Inconsistant escaping in the exclude files Inconsistent escaping in the exclude files Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant