Skip to content

Latest commit

 

History

History
21 lines (15 loc) · 1.13 KB

REVIEWING.md

File metadata and controls

21 lines (15 loc) · 1.13 KB

Reviewing a Modified / Newly Added CTF challenge

Challenges

Make sure that challenges are of good quality:

  • Difficulty is properly set.
  • The topic of the challenge is appropriate.
  • The provided solution is working.
  • Vulnerability and explanations are easy to understand.

Working on Pull Requests

You will review contributions as pull requests, following the PR review guidelines from GitHub. Contributions must follow the contributing guidelines.

Add your review as comments and request for changes to the PR until everything is ready to be approved. Add any comments regarding one or more explicit lines as review comments and only publish them together when submitting your review. Do not add each individual suggestion or comment as standalone. Before approving the PR, make sure that all Github Actions tests ended successfully. Once approved, either you or someone with proper access rights can use Rebase and merge to merge the PR commits and integrate the contribution.