Member Removal and Group Construction Potential Conflict

[ahache]

Summary

The remove operation updates an identity commitment to 0 on chain. The Group class prevents constructing or adding with any 0 identity commitments. As far as I can tell, this makes recreating a group with 0s (removals) in memory not possible using the Group class.

Trying to construct a group without the 0 entries gives a mismatch between the on-chain root and the computed root, which is expected but it prevents any further update or remove operations.

Possible Solution

Testing a custom Group class that allows for adding 0s, I was able to get a root match.

I'm not sure if there's an important reason for preventing 0 values in the Group class or if I'm missing a more obvious solution but figured I'd check anyway.

Context

I am using contracts and a subgraph that very closely follows the provided source and when querying the members of a group I'm getting all identity commitments and the 0 values from removed members.