Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendGrid Client, Memory Leaks, and IDisposable #1216

Open
larlewis opened this issue Jan 4, 2025 · 0 comments
Open

SendGrid Client, Memory Leaks, and IDisposable #1216

larlewis opened this issue Jan 4, 2025 · 0 comments

Comments

@larlewis
Copy link

larlewis commented Jan 4, 2025

The BaseClient should implement the IDisposable interface as it contains a disposable HttpClient.
Internally, none of the references to HttpRequestMessage or HttpResponseMessage are properly disposed of, either in a using statement or explicitly.

This causes the underlying streams and sockets to hang around leading to memory leaks and socket exhaustion.

https://learn.microsoft.com/en-us/dotnet/fundamentals/runtime-libraries/system-idisposable

I'm not sure why this has been ignored, and for so long, but it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant