Improving our review process

[ephys]

Just opening a thread to let you know that I'm currently working on our review process.

My main goal is to be able to use filter is:open is:pr review-requested:@me sort:created-asc -is:draft -author:@me -status:failure as a definitive work list

Progress

Preview Give feedback

1. Force all branch names to follow the <author>/<description> scheme, as this helps figuring out who the owner of a branch is
2. Replace our branch protections with rulesets, so we can allow renovate to bypass the reviewer requirement (but only the reviewer requirement). Removed renovate-approve. See meta: update dependency eslint-plugin-mocha to v10.3.0 sequelize#17094
3. meta: make renovate only open a PR if the CI check failed sequelize#17096
   +0
4. Create the @sequelize/code-reviewers team, to automatically assign the members of the team as new reviewers
5. meta: add codeowners sequelize#17095
   +0
6. Disable merge groups, as it's currently causing more headache than not having it.
7. meta: automatically update PRs that have auto merge enabled sequelize#17097
   +0
8. The first time a PR is put in draft, or has merge conflicts, have a bot print a message explaining that the PR won't appear in the list of reviewable PRs until these issues are fixed, but that the maintainers can still be pinged if help is required.
9. After the first "change request" of a PR, have a bot post a message saying to request a re-review from the user after implementing the changes

[ephys]

Still working on improving the review process, I'm now using two search presets to review everything:

• To Review: is:pr is:open draft:false review-requested:@me -reviewed-by:@me sort:created-asc -author:@me
• To Re-review: is:pr is:open draft:false user-review-requested:@me reviewed-by:@me sort:created-asc

Combined with Tab Renames & a bit of custom CSS to modify the Pull Requests page, it works pretty well and covers all repositories:

I started working on https://github.com/sequelize/pr-auto-update-and-conflict-notify to mark conflicted PRs with a label so they can be excluded from the search