Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which versions of Node.JS do we want to support? #5

Closed
sdepold opened this issue Nov 19, 2021 · 11 comments · Fixed by sequelize/sequelize#13721
Closed

Which versions of Node.JS do we want to support? #5

sdepold opened this issue Nov 19, 2021 · 11 comments · Fixed by sequelize/sequelize#13721

Comments

@sdepold
Copy link
Member

sdepold commented Nov 19, 2021

No description provided.

@sdepold
Copy link
Member Author

sdepold commented Nov 19, 2021

Related: sequelize/sequelize#13634

@fzn0x
Copy link
Member

fzn0x commented Nov 22, 2021

Look like > Active LTS is nice choice to be supported.

LTS version will be further supported by the Open JS foundation for a long time see here

@WikiRik
Copy link
Member

WikiRik commented Nov 22, 2021

I would support all LTS versions, so both active and maintenance. I would not support current versions of Node since changes to those might not be persisting.

@sdepold
Copy link
Member Author

sdepold commented Nov 23, 2021

It arose in the CLI since support for modules was supported.

Pedro:
Support all version that are officially support by the Node org.
However, if we remove support for particular version, it is a breaking change hence it should be a major release.
Do we want to release major version however, whenever Node version is deprecated?

Sascha: Could we just increase the supported node version in the package.json?

Pedro: It will result in a warning. npm/yarn is not preventing installation.

Gregory: At least yarn will prevent installing it that way.

Jesse: npm will install it nevertheless.

Sascha: Anybody against a major version release?

Constantin: Let's just let it sit in the back until we have enough reasons to do a major version bump.

Pedro: New features in Node 12 such as Array#flat will break in other versions. If major version release are easy to be upgraded to, it is fine to do it.

Consensus: Dropping support for Node 10 should imply a Major version update.

Q: When should we drop support for Node 10?

Maybe: Wrap up the TypeScript migration and only then drop support for Node 10 + major version upgrade?

Pedro: Let's add more breaking changes along with it.

@sdepold
Copy link
Member Author

sdepold commented Nov 23, 2021

--> #2

@sdepold
Copy link
Member Author

sdepold commented Nov 23, 2021

Rik: I do think this also goes hand in hand with which versions of Sequelize the CLI supports. Currently it's v5 and latest, but it might be good to only support the latest major version and have the same Node requirements there

@sdepold
Copy link
Member Author

sdepold commented Nov 23, 2021

Pedro: Community dislikes breaking changes

@WikiRik
Copy link
Member

WikiRik commented Dec 6, 2021

@sdepold shall we reopen it to do the follow up at the next meeting?

@sdepold
Copy link
Member Author

sdepold commented Dec 6, 2021

Sounds good :)

@sdepold
Copy link
Member Author

sdepold commented Dec 6, 2021

However I thought the consensus was that we accumulated enough breaking changes and upgrade to lts then?

@WikiRik
Copy link
Member

WikiRik commented Dec 6, 2021

That's true, not sure though why we didn't close it directly. Maybe to give people some extra time to respond?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants