-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which versions of Node.JS do we want to support? #5
Comments
Related: sequelize/sequelize#13634 |
Look like > Active LTS is nice choice to be supported. LTS version will be further supported by the Open JS foundation for a long time see here |
I would support all LTS versions, so both active and maintenance. I would not support current versions of Node since changes to those might not be persisting. |
It arose in the CLI since support for modules was supported. Pedro: Sascha: Could we just increase the supported node version in the package.json? Pedro: It will result in a warning. npm/yarn is not preventing installation. Gregory: At least yarn will prevent installing it that way. Jesse: npm will install it nevertheless. Sascha: Anybody against a major version release? Constantin: Let's just let it sit in the back until we have enough reasons to do a major version bump. Pedro: New features in Node 12 such as Array#flat will break in other versions. If major version release are easy to be upgraded to, it is fine to do it. Consensus: Dropping support for Node 10 should imply a Major version update. Q: When should we drop support for Node 10? Maybe: Wrap up the TypeScript migration and only then drop support for Node 10 + major version upgrade? Pedro: Let's add more breaking changes along with it. |
--> #2 |
Rik: I do think this also goes hand in hand with which versions of Sequelize the CLI supports. Currently it's v5 and latest, but it might be good to only support the latest major version and have the same Node requirements there |
Pedro: Community dislikes breaking changes |
@sdepold shall we reopen it to do the follow up at the next meeting? |
Sounds good :) |
However I thought the consensus was that we accumulated enough breaking changes and upgrade to lts then? |
That's true, not sure though why we didn't close it directly. Maybe to give people some extra time to respond? |
No description provided.
The text was updated successfully, but these errors were encountered: