Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some EMSG events missing from version 4.11.3 #7761

Open
sobbe81 opened this issue Dec 13, 2024 · 9 comments · Fixed by #7839
Open

Some EMSG events missing from version 4.11.3 #7761

sobbe81 opened this issue Dec 13, 2024 · 9 comments · Fixed by #7839
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@sobbe81
Copy link

sobbe81 commented Dec 13, 2024

Have you read the FAQ and checked for duplicate open issues?

If the problem is related to FairPlay, have you read the tutorial?

What version of Shaka Player are you using?

Can reproduce issue with versions 4.11.3 to 4.12.4
Can not reproduce issue with 4.11.2

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
Tried to add listener for emsg event but was not able to do that.

What browser and OS are you using?
Chrome, Mac OS 14.7.1

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

Will send this separately

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

abr
: 
advanced
: 
{minTotalBytes: 8000000}
defaultBandwidthEstimate
: 
10000000
[[Prototype]]
: 
Object
cmcd
: 
{enabled: true, sessionId: '5edd65db-650b-40c3-a3c1-58b9c3637197'}
drm
: 
{servers: {…}}
manifest
: 
{dash: {…}}
preferredAudioLanguage
: 
"sv"
streaming
: 
{bufferingGoal: 30}

What did you do?

Play linear stream over and ad break

What did you expect to happen?
Shaka Player to emit emsg events.

What actually happened?

emsg events are emitted but a lot of events missing

Are you planning send a PR to fix it?

@sobbe81 sobbe81 added the type: bug Something isn't working correctly label Dec 13, 2024
@shaka-bot shaka-bot added this to the v4.13 milestone Dec 13, 2024
@avelad
Copy link
Member

avelad commented Dec 23, 2024

I have tested your content for half an hour since it is live content and I have not seen that it has EMSG at any time

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Dec 23, 2024
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Dec 30, 2024
@sobbe81
Copy link
Author

sobbe81 commented Jan 7, 2025

Hi,

Unfortunately, you have to wait for an ad break in the linear stream and the ad break needs to be replaced with personalised ads. I will share a new url via email that is at least more likely to have have ads replaced.

We have been testing this using https://shaka-player-demo.appspot.com/demo and registered a listener for emsg events.

(new shaka.util.EventManager()).listen(shakaDemoMain.player_, 'emsg', (event) => {
    console.log('shaka emsg', ID3Parser.ParseArray(event.detail.messageData));
})

The ID3Parser.ParseArray() will interpret the data and print it. We have also done the same in our service using old shaka version.

Here are two screenshots that show the difference:

old_shaka new_shaka

If you look at YSEQ it will for example go from 1:4, 2:4, 3:4, 4:4 for the old shaka version but the new one will only show 1:4.

@shaka-bot reopen

@avelad
Copy link
Member

avelad commented Jan 7, 2025

@sobbe81 Can you review if #7839 solves your issue? Thanks!

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jan 7, 2025
@avelad avelad closed this as completed in e6ca059 Jan 7, 2025
@sobbe81
Copy link
Author

sobbe81 commented Jan 7, 2025

Hi,

It does not fix the issue.

I figured out that it was possible to run the test-page with older versions of shaka player. Ran these

https://v4-11-2-dot-shaka-player-demo.appspot.com/
https://v4-11-3-dot-shaka-player-demo.appspot.com/

with the same url and 4.11.2 works as expected but 4.11.3 does not. I noticed that the 4.11.3 version buffers and then continues playback at another position. With 4.11.3 I see a lot of these in the logs

´Jumping forward 13.52268099784851 seconds because of gap starting at 1736275468.464999 and ending at 1736275481.945´

Each advert is a separate period and I'm guessing that the jump is to the next period and the gap in EMSG-data is a (correct) consequence of the jump rather than the actual EMSG-handling. Also, looking at the change log between 4.11.2 and 4.11.3 there are some changes to multi-period handling which makes more sense to have cause this regression compared to error in emsg-handling that seems untouched for a long time.

If you test this using the url I provided and do not get any EMSG at all you can try to restart the stream to get ads replaced and EMSG data.

@shaka-bot reopen

@shaka-bot shaka-bot reopened this Jan 7, 2025
avelad added a commit that referenced this issue Jan 10, 2025
@sobbe81
Copy link
Author

sobbe81 commented Jan 17, 2025

Hi,

Were you able to reproduce this? @avelad

@avelad
Copy link
Member

avelad commented Jan 17, 2025

No, sorry !

@sobbe81
Copy link
Author

sobbe81 commented Jan 17, 2025

I just tested a multi-period stream from DASH-IF player and with that it's really easy to reproduce the jumping issue when there is a new period.

This url

https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/ee565ea510cb4b4d8df5f48918c3d6dc/index.mpd

Works without any issues in 4.11.2 but with 4.11.3 I get a lot of "Jumping forward ...." and playback jumps.

@avelad

@avelad
Copy link
Member

avelad commented Jan 17, 2025

Yes I can reproduce the "gap" issue in the main branch

@avelad avelad modified the milestones: v4.13, v4.14 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants