Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Safari player unable to access valid metadata for encrypted content #7856

Closed
akash-kush9 opened this issue Jan 9, 2025 · 2 comments
Closed
Labels
component: FairPlay The issue involves the FairPlay DRM status: working as intended The behavior is intended; this is not a bug

Comments

@akash-kush9
Copy link

akash-kush9 commented Jan 9, 2025

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?
Yes

What version of Shaka Player are you using?
4.7.13

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
Yes, i can reproduce the issue with the given encrypted on shaka player demo site.

https://shaka-player-demo.appspot.com/demo/#audiolang=en-IN;textlang=en-IN;uilang=en-IN;assetBase64=eyJuYW1lIjoiQmlnIEJ1Y2sgQnVubnkgKEZhaXJQbGF5KSIsInNob3J0TmFtZSI6IiIsImljb25VcmkiOiJodHRwczovL3N0b3JhZ2UuZ29vZ2xlYXBpcy5jb20vc2hha2EtYXNzZXQtaWNvbnMvYmlnX2J1Y2tfYnVubnkucG5nIiwibWFuaWZlc3RVcmkiOiJodHRwczovL25hLWZwcy5lemRybS5jb20vZGVtby9lemRybS9tYXN0ZXIubTN1OCIsInNvdXJjZSI6IkVaRFJNIiwiZm9jdXMiOmZhbHNlLCJkaXNhYmxlZCI6ZmFsc2UsImV4dHJhVGV4dCI6W10sImV4dHJhVGh1bWJuYWlsIjpbXSwiZXh0cmFDaGFwdGVyIjpbXSwiY2VydGlmaWNhdGVVcmkiOm51bGwsImRlc2NyaXB0aW9uIjpudWxsLCJpc0ZlYXR1cmVkIjpmYWxzZSwiZHJtIjpbIkZhaXJwbGF5IERSTSJdLCJmZWF0dXJlcyI6WyJIaWdoIGRlZmluaXRpb24iLCJITFMiLCJNUDQiLCJWT0QiXSwibGljZW5zZVNlcnZlcnMiOnsiX190eXBlX18iOiJtYXAiLCJjb20uYXBwbGUuZnBzIjoiaHR0cHM6Ly9mcHMuZXpkcm0uY29tL2FwaS9saWNlbnNlcy9iOTllZDllNS1jNjQxLTQ5ZDEtYmZhOC00MzY5MmI2ODZkZGIifSwib2ZmbGluZUxpY2Vuc2VTZXJ2ZXJzIjp7Il9fdHlwZV9fIjoibWFwIn0sImxpY2Vuc2VSZXF1ZXN0SGVhZGVycyI6eyJfX3R5cGVfXyI6Im1hcCJ9LCJyZXF1ZXN0RmlsdGVyIjpudWxsLCJyZXNwb25zZUZpbHRlciI6bnVsbCwiY2xlYXJLZXlzIjp7Il9fdHlwZV9fIjoibWFwIn0sImV4dHJhQ29uZmlnIjp7ImRybSI6eyJhZHZhbmNlZCI6eyJjb20uYXBwbGUuZnBzIjp7InNlcnZlckNlcnRpZmljYXRlVXJpIjoiaHR0cHM6Ly9mcHMuZXpkcm0uY29tL2RlbW8vdmlkZW8vZWxlaXN1cmUuY2VyIn19LCJzZXJ2ZXJzIjp7ImNvbS5hcHBsZS5mcHMiOiJodHRwczovL2Zwcy5lemRybS5jb20vYXBpL2xpY2Vuc2VzL2I5OWVkOWU1LWM2NDEtNDlkMS1iZmE4LTQzNjkyYjY4NmRkYiJ9fX0sImV4dHJhVWlDb25maWciOm51bGwsImFkVGFnVXJpIjpudWxsLCJpbWFWaWRlb0lkIjpudWxsLCJpbWFBc3NldEtleSI6bnVsbCwiaW1hQ29udGVudFNyY0lkIjpudWxsLCJpbWFNYW5pZmVzdFR5cGUiOm51bGwsIm1lZGlhVGFpbG9yVXJsIjpudWxsLCJtZWRpYVRhaWxvckFkc1BhcmFtcyI6bnVsbCwidXNlSU1BIjp0cnVlLCJtaW1lVHlwZSI6bnVsbH0=;panel=ALL_CONTENT;panelData=drm:FAIRPLAY,HLS;build=uncompiled

What browser and OS are you using?
Safari Mac

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
There are issue with client data so providing one is not possible. But i can reproduce issue with demo app.

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?
Basic configurations

What did you do?
Play encrypted content and get player stats value, few metadata are assigned NaN

What did you expect to happen?
Some valid values are assigned to metadata ex. streamBandwidth etc.
Adaption event is fired if possible when playback quality changes

What actually happened?
There is no "Adaption" event for encrypted content, some metadata are marked with NaN even at the end of playback

Are you planning to send a PR to fix it?
No

#7830

@akash-kush9 akash-kush9 added the type: bug Something isn't working correctly label Jan 9, 2025
@avelad avelad added the component: FairPlay The issue involves the FairPlay DRM label Jan 9, 2025
@shaka-bot shaka-bot added this to the v4.13 milestone Jan 9, 2025
@avelad
Copy link
Member

avelad commented Jan 9, 2025

If we set useNativeHlsForFairPlay = false the problem does not occur because we use MSE and our logic, by default useNativeHlsForFairPlay = true is used, and in that mode Safari does not provide all the information, that is why some fields are not filled.

@avelad avelad added status: working as intended The behavior is intended; this is not a bug and removed type: bug Something isn't working correctly labels Jan 9, 2025
@avelad avelad removed this from the v4.13 milestone Jan 9, 2025
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 9, 2025
@akash-kush9
Copy link
Author

okay, np

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FairPlay The issue involves the FairPlay DRM status: working as intended The behavior is intended; this is not a bug
Projects
None yet
Development

No branches or pull requests

3 participants