From 01ed7cda96cce990ffffb2875979b032e3d0a79a Mon Sep 17 00:00:00 2001 From: Patrick Weyck Date: Fri, 10 Jan 2025 15:47:19 +0100 Subject: [PATCH 1/2] Add line about required checks --- resources/guidelines/code/contribution.md | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/guidelines/code/contribution.md b/resources/guidelines/code/contribution.md index 5a266671f..45852df66 100644 --- a/resources/guidelines/code/contribution.md +++ b/resources/guidelines/code/contribution.md @@ -49,6 +49,7 @@ You are responsible for maintaining and updating your pull request. This include * Updating the code according to review feedback * Keeping the PR up to date with the target branch if conflicts arise * Making sure that all pipeline checks succeed on your PR + * We only have one required job called `check`. The job just makes sure that all integration tests are passing. It uses the action [`re-actors/alls-green`]( https://github.com/re-actors/alls-green) ::: tip Once your PR is public, avoid rebasing or force-pushing to the branch. Adding new commits makes it easier for reviewers to track changes and see what was updated in response to feedback. The PR will be automatically squashed when merged. From 7223a1b23fa30d5a07e35c093a706f87183a79ef Mon Sep 17 00:00:00 2001 From: Su <112690947+sushmangupta@users.noreply.github.com> Date: Wed, 15 Jan 2025 10:48:21 +0100 Subject: [PATCH 2/2] Update resources/guidelines/code/contribution.md --- resources/guidelines/code/contribution.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/guidelines/code/contribution.md b/resources/guidelines/code/contribution.md index 45852df66..03aace335 100644 --- a/resources/guidelines/code/contribution.md +++ b/resources/guidelines/code/contribution.md @@ -49,7 +49,7 @@ You are responsible for maintaining and updating your pull request. This include * Updating the code according to review feedback * Keeping the PR up to date with the target branch if conflicts arise * Making sure that all pipeline checks succeed on your PR - * We only have one required job called `check`. The job just makes sure that all integration tests are passing. It uses the action [`re-actors/alls-green`]( https://github.com/re-actors/alls-green) + * We only have one required job called `check`. The job just makes sure that all integration tests are passing. It uses the action [`re-actors/alls-green`](https://github.com/re-actors/alls-green) ::: tip Once your PR is public, avoid rebasing or force-pushing to the branch. Adding new commits makes it easier for reviewers to track changes and see what was updated in response to feedback. The PR will be automatically squashed when merged.