Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation #30

Open
GaryPWhite opened this issue Jan 21, 2022 · 2 comments
Open

Navigation #30

GaryPWhite opened this issue Jan 21, 2022 · 2 comments

Comments

@GaryPWhite
Copy link

Love your book!

I'm a keyboard person trying to navigate the non-single page, and noticed there wasn't an obvious cue or keyboard pattern to do so. Would you be opposed to me putting in a PR for arrow keys / AD to move been pages? I'm pretty familiar with gatsby and would be thrilled to contribute :)

@GaryPWhite
Copy link
Author

also.. might be a separate issue... but noticing that the pages actually reload between next/previous. I'm sure using a would have a little better performance, but there might be a reason you hadn't done that! Let me know, it should be trivial to put both of those in!

@shreyasminocha
Copy link
Owner

Would you be opposed to me putting in a PR for arrow keys / AD to move been pages? I'm pretty familiar with gatsby and would be thrilled to contribute

That sounds like a good idea. The PR's welcome!

but noticing that the pages actually reload between next/previous. I'm sure using a would have a little better performance

True. That would be cool, but only if there's a way to have it degrade gracefully when javascript is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants