-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push notification support #12
Comments
I may have some time, what are your thoughts about Firebase cloud messaging integration? |
I have not looked into push notification a huge amount. However, I think the aim would be to easily set up push notifications through the repo with the ability to create the integration you desire with ease. |
Since your clear in description about it being "opinionated", I though FCM would be a good choice. It has been effective and reliable in my projects. Although it would require user to set up a free project(takes ~1 minute) in firebase. The process is quite painless, would require user to update project name and key. |
@jasan-s I believe in this repository being opinionated but I think we need to draw the line when 3rd parties are involved because that is not just a technical decision anymore. We don't want people to have to be tied into firebase to use this repository. Maybe we could architect it so that if someone decides they wanted to make use of something like Twillio they could write their own module, or submit the module to the repository? i.e. we start off with FCM but this can easily swapped out for something else if desired. |
It would be good to have some form of push notification support within the repository. A the moment this has not been covered at all.
The approach is open for discussion.
The text was updated successfully, but these errors were encountered: