Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and new Persian layout from xkb PR !473 #18

Merged
merged 4 commits into from
Mar 12, 2023

Conversation

cs127
Copy link
Contributor

@cs127 cs127 commented Mar 11, 2023

  • Added a better installation script that modifies / patches evdev.xml and ir, instead of replacing them with entire files.
    • The installer script requires xmlstarlet to be installed in order to modify evdev.xml.
    • The installer script does not detect older versions of this layout. Make sure you uninstall them first.
  • Removed evdev.xml from the repo, since it's no longer needed.
  • Updated the Windows Persian layout to that of xkb !473 (not too different from how this repo was originally, only a few keys are changed).
  • Updated the README.

This might also hopefully fix #13, as long as they uninstall the layout (explained below), and then reinstall using the new installer script after this PR gets accepted.
To uninstall the layout, remove /usr/share/X11/xkb/symbols/ir_win if you have it (this will uninstall the current version of the project, which uses a separate ir_win file), and also, restore /usr/share/X11/xkb/symbols/ir and /usr/share/X11/xkb/rules/evdev.xml to their original versions (e.g. copy them over from a fresh install).

If you update xkb after the !473 gets accepted, the files in your system will automatically be replaced, and you don't need to uninstall the layout before updating, unless you are using the old ir_win-based version of this layout.

Copy link
Owner

@sinadarvi sinadarvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good. also i have looked at automatic installation, i think it would be perfect. thanks

@@ -1,45 +1,67 @@

I have been looking for a way to change to the keyboard layout of the Persian language for the Ubuntu operating system for a few years, which might be identical to the one I used to have while I was a windows user. This is probably the problem of most of the people who want to use Ubuntu. However, they cannot switch to it since it is almost impossible to type correctly using its predefined Persian language keyboard. Finally, this nightmare ended for me when I find what dear @KotlinFarsi did a few years ago. However, after following his instruction, I realized that this is not working at least on version 18.04 LTS+. So I decided to read his codes and generate an updated version of his file, which would work correctly.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove everything in this line after "predefined Persian language keyboard." I don't remember why i have added this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, I can do it my self later 😀

@sinadarvi sinadarvi merged commit 4750526 into sinadarvi:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work on Kubuntu 22.10
2 participants