Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to php 7.3? #117

Closed
Rotzbua opened this issue Nov 17, 2021 · 1 comment · May be fixed by #118
Closed

Bump version to php 7.3? #117

Rotzbua opened this issue Nov 17, 2021 · 1 comment · May be fixed by #118

Comments

@Rotzbua
Copy link

Rotzbua commented Nov 17, 2021

"phpunit/phpunit": "^9.0" requires php>=7.3 so php versions below can not be tested properly. Php versions below are EOL anyway. Sodium is also not available.
But composer still allows this old php versions. Shouldn't they be dropped?

If somebody wants to install the latest release anyway, it can be forced by composer with --ignore-platform-reqs or sticking to an old release.
@singpolyma
Copy link
Owner

sodium is optional (only gets used if you require that file) just like phpseclib is optional (but used so commonly in practise that it ended up listed as a requirement), but you're right that even CI doesn't run on anything less than 7.3 anymore so maybe we should drop the older versions.

@Rotzbua Rotzbua mentioned this issue Nov 17, 2021
Open
@Rotzbua Rotzbua closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add github actions to run tests Rotzbua/openpgp-php
2 participants
@singpolyma @Rotzbua