New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: `relNofollow` is not applied to link #43

Open

mhsdesign opened this issue Oct 23, 2023 · 0 comments

Collaborator

mhsdesign commented Oct 23, 2023

Bildschirmaufnahme.2023-10-23.um.17.43.32.mov

As far as i can tell, this

In https://github.com/sitegeist/Sitegeist.Archaeopteryx/blame/a003751455ccd6759cd6968dea11c08481ee4296/Neos.Ui/core/src/application/Dialog/Dialog.tsx#L33-L40 we filter out unsupported link options, but as we declare the field relNofollow internally with a different casing relNoFollow, we always filter it out:

Sitegeist.Archaeopteryx/Neos.Ui/core/src/application/Dialog/Settings.tsx

Lines 69 to 72 in a003751

    
           {props.enabledLinkOptions.includes('relNofollow') ? ( 
        
               <Field<boolean> 
        
                   type="checkbox" 
        
                   name="options.relNoFollow"

My thesis is that the relNofollow has never worked before.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment