Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Prevent the node editor from breaking for nodes with hashes #60

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

rolandschuetz
Copy link
Contributor

@rolandschuetz rolandschuetz commented Apr 10, 2024

Fixes #59

This was referenced Apr 10, 2024
@Benjamin-K
Copy link

Benjamin-K commented Apr 11, 2024

This will show links like node://XXXXXX#section as they are without resolving the node, right?
At least the editor can be used for such links, but IMO the main goal should be to see the selected node, too.
Nevertheless, this is way better than the current behavior. But the same check should then be used for assets, too.

@rolandschuetz
Copy link
Contributor Author

Exactly, since there was no decision on how the UI should look, this is just a bugfix preventing an internal server error and broken UI.

@Benjamin-K
Copy link

Could you add asset:// links with hashes to this PR, too? That would be awesome!

@rolandschuetz
Copy link
Contributor Author

@Benjamin-K Makes sense, I added it together with some tests

@gradinarufelix gradinarufelix force-pushed the BUGFIX/node-with-hash-handling branch from b1ff34f to 9842a52 Compare November 1, 2024 11:18
@gradinarufelix
Copy link
Contributor

@Benjamin-K FYI, I rebased this PR

@Alvadda
Copy link
Collaborator

Alvadda commented Jan 21, 2025

@rolandschuetz, I merged the latest main and tested it again, looks good the Error is gone. Will be merged in to main.

@Alvadda Alvadda merged commit 2722095 into sitegeist:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Node-Links with Hashes
4 participants