Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle image sizing for LocalImage, RemoteImage, PlaceholderImage #7

Open
s2b opened this issue Jan 19, 2023 · 0 comments
Open

Handle image sizing for LocalImage, RemoteImage, PlaceholderImage #7

s2b opened this issue Jan 19, 2023 · 0 comments
Assignees
@s2b

Comments

@s2b
Copy link
Collaborator

s2b commented Jan 19, 2023

Currently the extension requires getHeight() and getWidth(), which is only implemented by FalImage. Probably an Interface makes sense to differentiate the image implementations.

LocalImage: https://www.php.net/manual/de/function.getimagesize.php
RemoteImage: doesn't implement interface
PlaceholderImage: tbd
@s2b s2b self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s2b s2b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s2b