Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement move() function #195

Merged
merged 3 commits into from
Jan 27, 2025
Merged

feat: Implement move() function #195

merged 3 commits into from
Jan 27, 2025

Conversation

Jagadeeshftw
Copy link
Contributor

@Jagadeeshftw Jagadeeshftw commented Jan 19, 2025

Description

Detailed description of proposed changes

Related Issue(s)

Closes #192

Checklist:

  • Read the contributing docs (if this is your first contribution)

  • Verified this is not a duplicate of any existing pull request

  • Performed a self-review of the code

  • Rebased to the last commit of the target branch (or merged it into my branch)

  • Linked the issues which this PR resolves

  • Documented the changes in code (API docs will be generated automatically)

Copy link

co-lead bot commented Jan 19, 2025

Thanks for your PR @Jagadeeshftw. It will be reviewed shortly.

@Jagadeeshftw
Copy link
Contributor Author

@0xibs Move function implementation is completed. Kindly review it.

@Jagadeeshftw Jagadeeshftw marked this pull request as ready for review January 19, 2025 18:57
Copy link
Collaborator

@0xibs 0xibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Jagadeeshftw. Can you document your code and also add test cases?

@Jagadeeshftw Jagadeeshftw requested a review from 0xibs January 22, 2025 14:16
@0xibs 0xibs merged commit cc9c0b3 into sivicstudio:dev Jan 27, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete implementation for the move() function
2 participants