-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex rules do not appear to match Adblock Rules #11
Comments
Refer to this website for more info. |
Thanks! Does your fork https://github.com/faxotherapy/privoxy-adblock have the fixes described in your post? |
No, it doesn't. Just retrieve the archive that sits at the bottom of this post and you'll be good. |
Thanks again. Those look like useful mods. Do you mind if I ask a few follow-up questions?
Using a |
As Privoxy doesn't see the path side of a HTTPS request—it can only block the host part of a HTTPS request—I use ProxHTTPSProxy to allow Privoxy see it. |
Yes, you can use This works very well, and avoids the pitfalls of an SSL intercepting proxy. It is necessary to write the regex rules efficiently as a DFA in JavaScript. All these various AdBlock translation issues look like something that That would be a lot easier than writing a zillion one-off regex's for every scenario. |
No, I'm not. Certainly, based on what I learnt from your input, there's definitely another approach, much simpler than the overcomplicated translation from the add-on. |
I've created an EasyList to filtering proxy.pac file in the repo easylist-pac-privoxy. It's quite efficient and runs on mobile devices. Comments welcome. |
The forked repo adblock2privoxy, is a full-feature implementation of EasyList rules in Privoxy, complete with element hiding. This is a clever, efficient, and effective implementation: Privoxy handles the domain and path blocking rules using efficient and correct regular expressions, and Privoxy inserts targeted EasyList-based CSS files to handle element hiding. In addition to Privoxy, this approach requires a simple ( I'd encourage anyone interested in achieving network layer EasyList tracker and ad blocking to take a look at this approach. |
It be great if this could run from a router with DD-WRT O/S, which is a nix in itself, since DD-WRT has privoxy running on the system, all this work would need is a slight modification. If the system internal flash is to small , then a USB 3 stick could do the job. |
It would be straightforward to get You'd simply need to copy over the privoxy configuration and CSS files, and Regular updates could be rsync'd to the router. Here's an updating daemon example for macOS: com.github.essandess.adblock2privoxy.plist. |
Is this correct?
Using the example
&ad_box_
from the the easylist block, Privoxy shows no matches:http://config.privoxy.org/show-url-info?url=http%3A%2F%2Ftest.com%2F%26ad_box_
The exact string works, but I believe this should be a substring.
The text was updated successfully, but these errors were encountered: