From ea85dc8eefaf00ca5b1a9eecb763c719c86b3b5b Mon Sep 17 00:00:00 2001
From: Thomas Landauer <thomas@landauer.at>
Date: Wed, 2 Oct 2024 16:14:58 +0200
Subject: [PATCH 1/2] Adding more dedicated exceptions

---
 src/Smalot/PdfParser/Exception/EmptyPdfException.php   |  7 +++++++
 .../PdfParser/Exception/MissingPdfHeaderException.php  |  7 +++++++
 src/Smalot/PdfParser/RawData/RawDataParser.php         | 10 ++++++----
 3 files changed, 20 insertions(+), 4 deletions(-)
 create mode 100644 src/Smalot/PdfParser/Exception/EmptyPdfException.php
 create mode 100644 src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php

diff --git a/src/Smalot/PdfParser/Exception/EmptyPdfException.php b/src/Smalot/PdfParser/Exception/EmptyPdfException.php
new file mode 100644
index 00000000..1fc8464f
--- /dev/null
+++ b/src/Smalot/PdfParser/Exception/EmptyPdfException.php
@@ -0,0 +1,7 @@
+<?php declare(strict_types = 1);
+
+namespace Smalot\PdfParser\Exception;
+
+class EmptyPdfException extends \Exception
+{
+}
diff --git a/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php b/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php
new file mode 100644
index 00000000..7295c492
--- /dev/null
+++ b/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php
@@ -0,0 +1,7 @@
+<?php declare(strict_types = 1);
+
+namespace Smalot\PdfParser\Exception;
+
+class MissingPdfHeaderException extends \Exception
+{
+}
diff --git a/src/Smalot/PdfParser/RawData/RawDataParser.php b/src/Smalot/PdfParser/RawData/RawDataParser.php
index a6256f21..bb8a0a9a 100644
--- a/src/Smalot/PdfParser/RawData/RawDataParser.php
+++ b/src/Smalot/PdfParser/RawData/RawDataParser.php
@@ -43,6 +43,8 @@
 namespace Smalot\PdfParser\RawData;
 
 use Smalot\PdfParser\Config;
+use Smalot\PdfParser\Exception\MissingPdfHeaderException;
+use Smalot\PdfParser\Exception\EmptyPdfException;
 
 class RawDataParser
 {
@@ -938,17 +940,17 @@ protected function getXrefData(string $pdfData, int $offset = 0, array $xref = [
      *
      * @return array array of parsed PDF document objects
      *
-     * @throws \Exception if empty PDF data given
-     * @throws \Exception if PDF data missing %PDF header
+     * @throws EmptyPdfException if empty PDF data given
+     * @throws MissingPdfHeaderException if PDF data missing `%PDF-` header
      */
     public function parseData(string $data): array
     {
         if (empty($data)) {
-            throw new \Exception('Empty PDF data given.');
+            throw new EmptyPdfException('Empty PDF data given.');
         }
         // find the pdf header starting position
         if (false === ($trimpos = strpos($data, '%PDF-'))) {
-            throw new \Exception('Invalid PDF data: missing %PDF header.');
+            throw new MissingPdfHeaderException('Invalid PDF data: Missing `%PDF-` header.');
         }
 
         // get PDF content string

From d9772be3a6b97a694eb7f3118ec1e0dfb3e09006 Mon Sep 17 00:00:00 2001
From: Konrad Abicht <hi@inspirito.de>
Date: Thu, 31 Oct 2024 09:27:58 +0100
Subject: [PATCH 2/2] Refined new exceptions; added NotImplementedException

also fixed some coding style issues
---
 .../PdfParser/Exception/EmptyPdfException.php     |  7 ++++++-
 .../Exception/MissingPdfHeaderException.php       |  7 ++++++-
 .../Exception/NotImplementedException.php         | 12 ++++++++++++
 src/Smalot/PdfParser/RawData/FilterHelper.php     | 15 +++++++++------
 src/Smalot/PdfParser/RawData/RawDataParser.php    |  2 +-
 5 files changed, 34 insertions(+), 9 deletions(-)
 create mode 100644 src/Smalot/PdfParser/Exception/NotImplementedException.php

diff --git a/src/Smalot/PdfParser/Exception/EmptyPdfException.php b/src/Smalot/PdfParser/Exception/EmptyPdfException.php
index 1fc8464f..9eda9ce2 100644
--- a/src/Smalot/PdfParser/Exception/EmptyPdfException.php
+++ b/src/Smalot/PdfParser/Exception/EmptyPdfException.php
@@ -1,7 +1,12 @@
-<?php declare(strict_types = 1);
+<?php
+
+declare(strict_types=1);
 
 namespace Smalot\PdfParser\Exception;
 
+/**
+ * This Exception is thrown when no PDF data was given.
+ */
 class EmptyPdfException extends \Exception
 {
 }
diff --git a/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php b/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php
index 7295c492..1dc7a733 100644
--- a/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php
+++ b/src/Smalot/PdfParser/Exception/MissingPdfHeaderException.php
@@ -1,7 +1,12 @@
-<?php declare(strict_types = 1);
+<?php
+
+declare(strict_types=1);
 
 namespace Smalot\PdfParser\Exception;
 
+/**
+ * This Exception is thrown when the %PDF- header is missing.
+ */
 class MissingPdfHeaderException extends \Exception
 {
 }
diff --git a/src/Smalot/PdfParser/Exception/NotImplementedException.php b/src/Smalot/PdfParser/Exception/NotImplementedException.php
new file mode 100644
index 00000000..a6700447
--- /dev/null
+++ b/src/Smalot/PdfParser/Exception/NotImplementedException.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smalot\PdfParser\Exception;
+
+/**
+ * This Exception is thrown when a functionality has not yet been implemented.
+ */
+class NotImplementedException extends \Exception
+{
+}
diff --git a/src/Smalot/PdfParser/RawData/FilterHelper.php b/src/Smalot/PdfParser/RawData/FilterHelper.php
index 4bab847e..717c5c7f 100644
--- a/src/Smalot/PdfParser/RawData/FilterHelper.php
+++ b/src/Smalot/PdfParser/RawData/FilterHelper.php
@@ -42,6 +42,8 @@
 
 namespace Smalot\PdfParser\RawData;
 
+use Smalot\PdfParser\Exception\NotImplementedException;
+
 class FilterHelper
 {
     protected $availableFilters = ['ASCIIHexDecode', 'ASCII85Decode', 'LZWDecode', 'FlateDecode', 'RunLengthDecode'];
@@ -54,7 +56,8 @@ class FilterHelper
      *
      * @return string Decoded data string
      *
-     * @throws \Exception if a certain decode function is not implemented yet
+     * @throws \Exception
+     * @throws \Smalot\PdfParser\Exception\NotImplementedException if a certain decode function is not implemented yet
      */
     public function decodeFilter(string $filter, string $data, int $decodeMemoryLimit = 0): string
     {
@@ -75,15 +78,15 @@ public function decodeFilter(string $filter, string $data, int $decodeMemoryLimi
                 return $this->decodeFilterRunLengthDecode($data);
 
             case 'CCITTFaxDecode':
-                throw new \Exception('Decode CCITTFaxDecode not implemented yet.');
+                throw new NotImplementedException('Decode CCITTFaxDecode not implemented yet.');
             case 'JBIG2Decode':
-                throw new \Exception('Decode JBIG2Decode not implemented yet.');
+                throw new NotImplementedException('Decode JBIG2Decode not implemented yet.');
             case 'DCTDecode':
-                throw new \Exception('Decode DCTDecode not implemented yet.');
+                throw new NotImplementedException('Decode DCTDecode not implemented yet.');
             case 'JPXDecode':
-                throw new \Exception('Decode JPXDecode not implemented yet.');
+                throw new NotImplementedException('Decode JPXDecode not implemented yet.');
             case 'Crypt':
-                throw new \Exception('Decode Crypt not implemented yet.');
+                throw new NotImplementedException('Decode Crypt not implemented yet.');
             default:
                 return $data;
         }
diff --git a/src/Smalot/PdfParser/RawData/RawDataParser.php b/src/Smalot/PdfParser/RawData/RawDataParser.php
index bb8a0a9a..a94be8a7 100644
--- a/src/Smalot/PdfParser/RawData/RawDataParser.php
+++ b/src/Smalot/PdfParser/RawData/RawDataParser.php
@@ -43,8 +43,8 @@
 namespace Smalot\PdfParser\RawData;
 
 use Smalot\PdfParser\Config;
-use Smalot\PdfParser\Exception\MissingPdfHeaderException;
 use Smalot\PdfParser\Exception\EmptyPdfException;
+use Smalot\PdfParser\Exception\MissingPdfHeaderException;
 
 class RawDataParser
 {