Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare View, Usability: Filter Missing Data per CSS per default #206

Open
1 of 2 tasks
smarr opened this issue Jun 26, 2024 · 1 comment · Fixed by #208
Open
1 of 2 tasks

Compare View, Usability: Filter Missing Data per CSS per default #206

smarr opened this issue Jun 26, 2024 · 1 comment · Fixed by #208
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@smarr
Copy link
Owner

smarr commented Jun 26, 2024

See for example:

https://rebench.dev/TruffleSOM/compare/f614a64c4558d4f744d814770318ea79e873743d..7d8f9c2d0ec479e5bca841516537ecb4b1a5b286

  • 1. There's a big table with missing data. I think we can use CSS to hide everything after a number of rows. But would be good to have a final row in the filtered table that allows us to expand it on demand.

  • 2. There are many missing entries in the table. I think we also want to hide them with CSS class normally.

The top right corner has a filter icon. When clicking on that, we should be able to enable/disable that particular filtering.

@smarr smarr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 26, 2024
@smarr smarr moved this to Backlog ReBenchDB in ReBench Summer 2024 Jul 1, 2024
smarr added a commit that referenced this issue Jul 16, 2024
@smarr
Copy link
Owner Author

smarr commented Jul 16, 2024

@F12-Syntex implemented the first bit of this with #208. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Backlog ReBenchDB
1 participant