Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme modification #34

Open
aleskl opened this issue Nov 26, 2016 · 8 comments
Open

Theme modification #34

aleskl opened this issue Nov 26, 2016 · 8 comments

Comments

@aleskl
Copy link

aleskl commented Nov 26, 2016

Hi,
tried to modify theme using theme inheritance (as described in https://getgrav.org/blog/theme-development-with-inheritance), but when I create a child theme and activate it, I get only unstyled content, so I guess I'm missing some extra file to properly import CSS.

Cheers, Ales

@ghost
Copy link

ghost commented Jan 22, 2017

I second that. I just created a whole site for a customer editing a copy of the theme.
But inheriting is way cleaner and future proof.

@ganar
Copy link

ganar commented Mar 14, 2017

Third time's the charm: inheritance does not work with Bones, a template that otherwise would be a great base to build on.

This problem was reported here

@core77
Copy link

core77 commented Mar 14, 2017

Hi. Bones is well done i think. The switches in the Backend are nice, to toggle specific css/js on and off.

Seems like the switches are useless, when you want do use the Foundation SCSS settings file.
Because of that I'll try to start with a simple boilerplate and compile Sass files with Gulp (automatic browser reload on SCSS file and twig template changes):
https://github.com/core77/grav-theme-foundation

@ganar
Copy link

ganar commented Mar 14, 2017

Hi @core77: I saw the foundation theme that you referenced, but it looked that the last commit was a long time ago. Is the code of the theme up to date?

@core77
Copy link

core77 commented Mar 14, 2017

I commited yesterday.

I'm the second one, who forked the repo. Perhaps you looked at another folk's fork.

@ganar
Copy link

ganar commented Mar 14, 2017

I can see that in your fork: but where are all the foundation SCSS files? which version of foundation are you using?

@core77
Copy link

core77 commented Mar 14, 2017

Doesn't make sense too keep them in the repo. There's a reference in the bower.json file.

Fire a bower install (or later bower update) and you have them in the bower_components folder.

@ganar
Copy link

ganar commented Mar 14, 2017

Ah : ok. I'll try with your repo, forget about inheritance, and don't use bones. Thanks a lot for your help @core77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants