feat: Add support for customer compute service account #51
Conversation
Signed-off-by: Hatem Nawar <[email protected]>
hnawar
changed the title
|
And @hnawar I would say you would want to test this with an actual service account and verify it works. |
|
I have tested this with a service account and can confirm it is passed on and the VM was using the service account specified. |
|
In that case, we just need @johanneskoester blessing. |
|
Warning Rate limit exceeded@johanneskoester has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Ok, fine with me. |
johanneskoester
merged commit 5e59f8c
into
snakemake:feat/service-account
|
Merged into non-fork PR #52 for testing with our credentials. |
…#52) Test for PR #51. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for specifying a custom compute service account in the `hello_world` rule, enhancing flexibility for cloud interactions. - Introduced a new method to retrieve service account information, providing better control over job allocations. - **Bug Fixes** - Updated `.gitignore` to exclude the `poetry.lock` file, ensuring cleaner version control. - **Documentation** - Enhanced documentation for the `hello_world` rule to include the new `googlebatch_service_account` parameter, improving user guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Hatem Nawar <[email protected]> Co-authored-by: Hatem <[email protected]> Co-authored-by: hatem.nawar <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2024-08-14) ### Features * Add support for customer compute service account ([#51](#51), [@hnawar](https://github.com/hnawar)) ([#52](#52)) ([8678e20](8678e20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vsoch @johanneskoester
I am supporting a snakemake user to migrate to Batch, one of the requirement that came up was the use of custom service account.
This is my attempt to add support for it, I would appreciate your guidance on how best to contribute and test this PR