Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .lcov report #11

Closed
MaksymilianDemitraszek opened this issue Aug 6, 2024 · 0 comments · Fixed by #23 or #24
Closed

Generate .lcov report #11

MaksymilianDemitraszek opened this issue Aug 6, 2024 · 0 comments · Fixed by #23 or #24
Assignees

Comments

@MaksymilianDemitraszek
Copy link
Contributor

The overview

We should generate .lcov reports using: #9 and #10

The reports shall include:

  • line coverage
  • function coverage
    We should omit branch coverage at this stage.

Lines in coverage are marked:

  • hitable - covered - green 🟢
  • hitable - missing - red 🔴
  • not hittable - no color ⚪

Reports shall be generated based on cairo vm trace pc's, we should consider a single contract execution for now (only the root of the profiler trace).

Lines states

hitable - covered - green 🟢
Happens when there is a corresponding casm instruction in mappings
and
in cairo vm trace there is a pc pointing to this instruction

hitable - missing - red 🔴
Happens when there is a corresponding casm instruction in mappings
and
in cairo vm trace there is no pc pointing to this instruction

not hittable - no color ⚪
Happens when there is no corresponding casm instruction in mappings, this happens if some code is removed by the compiler, inlined etc.

This was linked to pull requests Aug 26, 2024
@ksew1 ksew1 removed a link to a pull request Aug 28, 2024
ksew1 added a commit that referenced this issue Aug 28, 2024
@ksew1 ksew1 mentioned this issue Aug 28, 2024
ksew1 added a commit that referenced this issue Aug 28, 2024
@ksew1 ksew1 closed this as completed in #23 Aug 28, 2024
ksew1 added a commit that referenced this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants