Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor outside execution functions #1537

Open
franciszekjob opened this issue Dec 14, 2024 · 25 comments
Open

Refactor outside execution functions #1537

franciszekjob opened this issue Dec 14, 2024 · 25 comments
Assignees
Labels

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Dec 14, 2024

Feature Request

  1. outside_execution_to_typed_data function should be a method of OutsideExecution, e.g.
@dataclass
class OutsideExecution:
    ...
    def to_typed_data(...) -> TypedData:

This requires resolving cycling imports errors, discussed here -> #1530 (comment)

  1. OutsideExecution. to_abi_dict() should ideally use schema while creating dict.
@baitcode
Copy link
Contributor

@franciszekjob I'm happy to tackle that issue, if you need help, of course. But would be nice to make a call to discuss.

@franciszekjob
Copy link
Collaborator Author

@franciszekjob I'm happy to tackle that issue, if you need help, of course. But would be nice to make a call to discuss.

Sure, you can address this once #1530 is done 😄

@kengoon
Copy link

kengoon commented Dec 15, 2024

I’d like to work on this.

@franciszekjob
Copy link
Collaborator Author

@kengoon sorry but @baitcode will be already tackling this issue.

@franciszekjob franciszekjob changed the title Refactor outside_execution_to_typed_data Refactor outside execution functions Dec 16, 2024
@pheobeayo
Copy link

Can I jump on this task?

@nottherealalanturing
Copy link

Let me try this one!

@franciszekjob
Copy link
Collaborator Author

franciszekjob commented Dec 20, 2024

@baitcode would you like to work on this one as we discussed?

@kengoon
Copy link

kengoon commented Dec 20, 2024

@franciszekjob if his answer is negative, I'm still up for this.

@aidenwong812
Copy link

I’m interested in this one.

@jaykayudo
Copy link

Is this issue still available?

@kengoon
Copy link

kengoon commented Jan 2, 2025

@franciszekjob It's been 13 days with no response, can I take on this?

@baitcode
Copy link
Contributor

baitcode commented Jan 3, 2025

@franciszekjob I'd love to but currently working on other issues. Can it wait for another week?

@nottherealalanturing
Copy link

@franciszekjob I can take it

@franciszekjob
Copy link
Collaborator Author

@franciszekjob I'd love to but currently working on other issues. Can it wait for another week?

@baitcode Yes

@BlessingEmejulu
Copy link

Can I start working on this?

@franciszekjob
Copy link
Collaborator Author

@BlessingEmejulu sorry, but another contributor will address it.

@emarc99
Copy link

emarc99 commented Jan 7, 2025

May I try my hand at this?

@Nityam573
Copy link

Can I take this from here?

@uzochukwuV
Copy link

I’d love to work on this task.

@baitcode
Copy link
Contributor

baitcode commented Jan 9, 2025

@franciszekjob Ready to start on 13th of Jan.

@franciszekjob
Copy link
Collaborator Author

@baitcode Ok, cool. Would you be also able to handle #1546?

@baitcode
Copy link
Contributor

@franciszekjob Yes, sure, that is an easy one.

@ekumamatthew
Copy link

I’m interested in this one.

@baitcode
Copy link
Contributor

@franciszekjob could you assign me to that one, please?

@franciszekjob
Copy link
Collaborator Author

@baitcode done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests