Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtests/test_nopython_callprofiler.cpp timing is unstable #347

Open
yungyuc opened this issue Jun 5, 2024 · 6 comments
Open

gtests/test_nopython_callprofiler.cpp timing is unstable #347

yungyuc opened this issue Jun 5, 2024 · 6 comments
Labels
bug Something isn't working performance Profiling, runtime, and memory consumption test testing and continuous integration

Comments

@yungyuc
Copy link
Member

yungyuc commented Jun 5, 2024

See https://github.com/solvcon/modmesh/actions/runs/9378360062/job/25821452032#step:9:275 :

/Users/runner/work/modmesh/modmesh/gtests/test_nopython_callprofiler.cpp:175: Failure
Value of: diff_time(node1->data().total_time, uniqueTime1 + uniqueTime2)
  Actual: false
Expected: true

The test should use a more stable way to test for time.

@yungyuc yungyuc added bug Something isn't working test testing and continuous integration performance Profiling, runtime, and memory consumption labels Jun 5, 2024
@tigercosmos tigercosmos moved this from Todo to In Progress in tabular data processing Jun 6, 2024
@tigercosmos
Copy link
Collaborator

@yungyuc I checked all scheduled actions, no errors before, it's probably the PR issue.
https://github.com/solvcon/modmesh/actions?page=3&query=event%3Aschedule

@yungyuc
Copy link
Member Author

yungyuc commented Jun 6, 2024

Right, it is a random failure. Please take a look at my quote and link in the issue description.

@tigercosmos
Copy link
Collaborator

@yungyuc No, it's not a random failure, it never happens in the past few months

@yungyuc
Copy link
Member Author

yungyuc commented Jun 6, 2024

I see what you meant. It does not happen with scheduled runs, but only happens with PR runs?

@tigercosmos
Copy link
Collaborator

@yungyuc yes, that's what I meant. The current code should be very stable in the master branch, so the PR owner need to check why it failed.

@yungyuc
Copy link
Member Author

yungyuc commented Jun 6, 2024

This is good finding. Thanks, @tigercosmos . Let me unassign this issue from you and move it out in progress. We should revisit when we find another occasion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance Profiling, runtime, and memory consumption test testing and continuous integration
Projects
Status: No status
Development

No branches or pull requests

2 participants