Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add option to set bind IP for debugger #23

Open
thieman opened this issue Jan 6, 2017 · 4 comments
Open

Proposal: Add option to set bind IP for debugger #23

thieman opened this issue Jan 6, 2017 · 4 comments

Comments

@thieman
Copy link

thieman commented Jan 6, 2017

My reading of this line is that currently the debugger only ever binds itself to 127.0.0.1. This is a sensible default, but it makes attaching a remote debugger to a running v8eval instance impossible without layering on additional tooling.

Would you be open to making this configurable, probably as a constructor to EnableDebugger? If so I might look into providing a patch.

@thieman
Copy link
Author

thieman commented Jan 6, 2017

As an alternative for anyone else having this problem, you can run socat on the same machine as v8eval to forward a remote request through the local interface.

@YoshiyukiMineo
Copy link
Member

Certainly there is no need to reject remote debugger connections.
I think it's another simple solution to replace 127.0.0.1 with 0.0.0.0.
What do you think?

@thieman
Copy link
Author

thieman commented Jan 11, 2017

There is nothing in v8eval which makes the debugger run by default, is there? As long as that's the case, I think we could get away with defaulting to 0.0.0.0, but we would want to make it very explicit in the docs that we bind on all addresses.

@YoshiyukiMineo
Copy link
Member

v8eval never run the debug server until EnableDebugger is called. I will replace 127.0.0.1 with 0.0.0.0 and write it explicitly in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants