Major overhaul for Sopel 8 and Python 3-only #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converted to entry-point plugin * Package name is now `sopel-stocks` * Supports minimum Python 3.8 * Supports minimum Sopel 8.0 * Updated imports * Updated README * Created changelog in NEWS file * Added .gitignore file I was able to test the plugin successfully with a free API key from Finnhub. Linting with flake8 shows nothing more serious than "line too long" errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sopel-stocksLinting with flake8 shows nothing more serious than "line too long" errors. Running the
flake8commands from thepython-tests.ymlworkflow now yields zero warnings with the custom line length set there.I was able to test successfully with a free key from Finnhub. Though this doesn't confirm that the other providers work, it does prove that the file reorganization (and style cleanup) hasn't obviously broken anything.
Releasing
This changes the package name, like sopel-irc/sopel-imdb#17. Likewise, if you want, I'm happy to help set up Trusted Publishing and assist with creating a post-release to direct users from
sopel_modules.stocksto the newsopel-stockspackage.