[BUG]: Reinitialized agents

[XuhuiZhou]

Description of the bug

The agents have been reinitialized here, which is a problematic behavior since the agents have been initialized before:

sotopia/sotopia/server.py

Line 119 in 184d1ca

for agent_name, agent_model in zip(env.agents, agents_model_names):

Steps To Reproduce

Just need to look at it

Additional Information

No response

[XuhuiZhou]

@ProKil

I am proposing removing these lines:

    agents_model_names = [model_dict["agent1"], model_dict["agent2"]]
    for agent_name, agent_model in zip(env.agents, agents_model_names):
        if agent_model == "human":
            agents[agent_name] = HumanAgent(agent_name)
        elif agent_model == "redis":
            agents[agent_name] = RedisAgent(agent_name)
        elif script_like and not json_in_script:
            agents[agent_name] = ScriptWritingAgent(
                agent_name,
                model_name=agent_model,
                background=env.background,
                agent_names=env.agents,
            )
        else:
            agents[agent_name] = LLMAgent(
                agent_name, model_name=agent_model, script_like=script_like
            )

[ProKil]

Yes.

More generally, we can modularize the server behavior:

1. EnvironmentAgentCombo comes with initialized agents and environments, which will not be initialized for the second time in the server,
2. A static class method EnvironmentAgentCombo.new() returns a new EnvironmentAgentCombo which takes a configuration object as input and initialize the agents and the environment.

[XuhuiZhou]

Not sure if I understand the 2 point. But here's the branch for the purpose of making Sotopia more organic for other applications. #86

[ProKil]

Has this already been solved in #69 ?