Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract creation of mock maps in route.service into helper #25

Open
0815Sailsman opened this issue Sep 22, 2023 · 0 comments
Open

Extract creation of mock maps in route.service into helper #25

0815Sailsman opened this issue Sep 22, 2023 · 0 comments
Assignees
@0815Sailsman
Labels
dev-feature new feature but for the dev to make work easier refactor improve code quality

Comments

@0815Sailsman
Copy link
Collaborator

lots of duplication and only minor details changed between different test cases.
specifically visible in unlocking suite.
move into epic functions that also improve readability
@0815Sailsman 0815Sailsman added refactor improve code quality dev-feature new feature but for the dev to make work easier labels Sep 22, 2023
@0815Sailsman 0815Sailsman self-assigned this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0815Sailsman 0815Sailsman

Labels
dev-feature new feature but for the dev to make work easier refactor improve code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0815Sailsman