Skip to content

Commit

Permalink
Don't ship Noa when vendoring (#1462)
Browse files Browse the repository at this point in the history 
Signed-off-by: Juan Cruz Viotti <[email protected]>
  • Loading branch information
@jviotti
jviotti authored Jan 21, 2025
1 parent cd623c4 commit d3436cf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions vendorpull.mask
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ vendor/googlebenchmark.mask
vendor/referencing-suite
vendor/referencing-suite.mask
vendor/jsonschema-test-suite
vendor/noa
cmake/FindGoogleTest.cmake
.editorconfig
.ackrc
Expand All @@ -34,5 +35,3 @@ cmake/FindGoogleTest.cmake
Brewfile
Brewfile.lock.json
CHANGELOG.markdown
vendor/noa/vendor/googletest
vendor/noa/vendor/googlebenchmark

8 comments on commit d3436cf

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
JSON_Array_Of_Objects_Unique 453.9812596828667 ns/iter 449.33601736923373 ns/iter 1.01
JSON_Parse_1 30115.170721224036 ns/iter 30156.467458944066 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 55.32241394931231 ns/iter 55.32131747802451 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 147.61673287849126 ns/iter 138.31156464084108 ns/iter 1.07
Pointer_Object_Traverse 44.914351388795026 ns/iter 44.98762692182171 ns/iter 1.00
Pointer_Object_Try_Traverse 49.96798914111001 ns/iter 50.01374109999688 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.3646054116624 ns/iter 352.5677761250012 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
Pointer_Object_Traverse 43.75639248084393 ns/iter 44.69701046021094 ns/iter 0.98
Pointer_Object_Try_Traverse 22.511511442233207 ns/iter 22.420786335936146 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.2416986424351 ns/iter 214.40573691616103 ns/iter 0.99
JSON_Array_Of_Objects_Unique 390.63840572528267 ns/iter 399.03176446057 ns/iter 0.98
JSON_Parse_1 32938.516577842245 ns/iter 32761.511638886124 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 72.07298450139372 ns/iter 72.00111306038184 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 139.2796629722018 ns/iter 154.31607213077748 ns/iter 0.90

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
JSON_Array_Of_Objects_Unique 446.1058124999795 ns/iter 446.9065811857618 ns/iter 1.00
JSON_Parse_1 81469.86607141368 ns/iter 79723.01339285487 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 64.46757142857759 ns/iter 70.02922991072222 ns/iter 0.92
JSON_Equality_Helm_Chart_Lock 197.40459798252027 ns/iter 195.21748012422222 ns/iter 1.01
Pointer_Object_Traverse 50.657139999998435 ns/iter 50.632260000008955 ns/iter 1.00
Pointer_Object_Try_Traverse 75.95325892858337 ns/iter 76.03314732143676 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 178.23077756005873 ns/iter 178.8504534688098 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
JSON_Array_Of_Objects_Unique 356.4956509363173 ns/iter 401.1147872576045 ns/iter 0.89
JSON_Parse_1 22779.077225342986 ns/iter 24628.32681867625 ns/iter 0.92
JSON_Fast_Hash_Helm_Chart_Lock 50.92812846316271 ns/iter 55.78855703756165 ns/iter 0.91
JSON_Equality_Helm_Chart_Lock 140.24681520653618 ns/iter 154.91709954526158 ns/iter 0.91
Pointer_Object_Traverse 15.75686914948103 ns/iter 20.17496196977734 ns/iter 0.78
Pointer_Object_Try_Traverse 35.403147587426325 ns/iter 36.27885549928748 ns/iter 0.98
Pointer_Push_Back_Pointer_To_Weak_Pointer 184.66237732253344 ns/iter 201.79698766804069 ns/iter 0.92

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
JSON_Array_Of_Objects_Unique 445.18179370123227 ns/iter 446.9065811857618 ns/iter 1.00
JSON_Parse_1 81457.18750000189 ns/iter 79723.01339285487 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 65.69608035713414 ns/iter 70.02922991072222 ns/iter 0.94
JSON_Equality_Helm_Chart_Lock 200.08635715056357 ns/iter 195.21748012422222 ns/iter 1.02
Pointer_Object_Traverse 50.76893000000382 ns/iter 50.632260000008955 ns/iter 1.00
Pointer_Object_Try_Traverse 75.79619419642977 ns/iter 76.03314732143676 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 190.22372234140613 ns/iter 178.8504534688098 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
JSON_Array_Of_Objects_Unique 439.5780634214989 ns/iter 449.33601736923373 ns/iter 0.98
JSON_Parse_1 30262.67378665774 ns/iter 30156.467458944066 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 55.35855034205425 ns/iter 55.32131747802451 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 143.133154724085 ns/iter 138.31156464084108 ns/iter 1.03
Pointer_Object_Traverse 44.932415088588094 ns/iter 44.98762692182171 ns/iter 1.00
Pointer_Object_Try_Traverse 49.20853205839887 ns/iter 50.01374109999688 ns/iter 0.98
Pointer_Push_Back_Pointer_To_Weak_Pointer 354.222797792722 ns/iter 352.5677761250012 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
Pointer_Object_Traverse 45.06791787439412 ns/iter 44.69701046021094 ns/iter 1.01
Pointer_Object_Try_Traverse 22.419665198255462 ns/iter 22.420786335936146 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.65496575871 ns/iter 214.40573691616103 ns/iter 1.00
JSON_Array_Of_Objects_Unique 390.8472011158526 ns/iter 399.03176446057 ns/iter 0.98
JSON_Parse_1 32399.712312256608 ns/iter 32761.511638886124 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 72.05035605357376 ns/iter 72.00111306038184 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 136.94169315629506 ns/iter 154.31607213077748 ns/iter 0.89

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: d3436cf Previous: cd623c4 Ratio
JSON_Array_Of_Objects_Unique 423.7705615854934 ns/iter 401.1147872576045 ns/iter 1.06
JSON_Parse_1 29922.804748947176 ns/iter 24628.32681867625 ns/iter 1.21
JSON_Fast_Hash_Helm_Chart_Lock 66.50190730695144 ns/iter 55.78855703756165 ns/iter 1.19
JSON_Equality_Helm_Chart_Lock 175.2318701128042 ns/iter 154.91709954526158 ns/iter 1.13
Pointer_Object_Traverse 21.48994447892436 ns/iter 20.17496196977734 ns/iter 1.07
Pointer_Object_Try_Traverse 43.262527160606005 ns/iter 36.27885549928748 ns/iter 1.19
Pointer_Push_Back_Pointer_To_Weak_Pointer 244.32518163392535 ns/iter 201.79698766804069 ns/iter 1.21

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.