Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FlatFileSchemaResolver enforces relative references #1425

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 7, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 5a370db Previous: 08ea8d9 Ratio
JSON_Array_Of_Objects_Unique 432.8347907342049 ns/iter 448.99102806627013 ns/iter 0.96
JSON_Parse_1 30191.591089277976 ns/iter 29977.227723618562 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 54.791059629022385 ns/iter 54.68012567188576 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 149.40980890401178 ns/iter 149.48033985843307 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.1792083216735403 ns/iter 2.203977063137023 ns/iter 0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1854157476593206 ns/iter 2.2104484593051104 ns/iter 0.99
Regex_Period_Asterisk 2.180126853206083 ns/iter 2.1991541543015054 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 2.1822070968219003 ns/iter 2.1921508727627614 ns/iter 1.00
Regex_Period_Plus 2.49370529325278 ns/iter 2.486290124674428 ns/iter 1.00
Regex_Period 2.487460747566119 ns/iter 2.4854984013104757 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.488488516709047 ns/iter 2.4859983770520535 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4879411593684457 ns/iter 2.485744414467124 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.419726599557029 ns/iter 3.416262530572305 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4194604241051514 ns/iter 2.1950793354480327 ns/iter 1.56
Regex_Caret_X_Hyphen 12.49535911570113 ns/iter 13.048821086520212 ns/iter 0.96
Regex_Period_Md_Dollar 73.51416292800276 ns/iter 74.47197122949497 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 7.1470893647749545 ns/iter 6.22303867854373 ns/iter 1.15
Regex_Caret_Period_Range_Dollar 3.731589132266073 ns/iter 3.735530556719767 ns/iter 1.00
Regex_Nested_Backtrack 493.2324176292595 ns/iter 494.4804998267498 ns/iter 1.00
Pointer_Object_Traverse 44.97927488458637 ns/iter 44.78886507599523 ns/iter 1.00
Pointer_Object_Try_Traverse 52.486784558953346 ns/iter 52.65845835403999 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.2940001408543 ns/iter 352.25705860426945 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 5a370db Previous: 08ea8d9 Ratio
JSON_Array_Of_Objects_Unique 387.1083014083474 ns/iter 363.1005432169859 ns/iter 1.07
JSON_Parse_1 23507.134917094256 ns/iter 29350.68247765509 ns/iter 0.80
JSON_Fast_Hash_Helm_Chart_Lock 52.88772147403094 ns/iter 55.44076688666669 ns/iter 0.95
JSON_Equality_Helm_Chart_Lock 153.42549365847165 ns/iter 159.97529624680226 ns/iter 0.96
Regex_Lower_S_Or_Upper_S_Asterisk 1.6826138698780182 ns/iter 1.8258450555993455 ns/iter 0.92
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.6898752687227634 ns/iter 1.8632866279841254 ns/iter 0.91
Regex_Period_Asterisk 1.6753984769813979 ns/iter 1.9398793997879733 ns/iter 0.86
Regex_Group_Period_Asterisk_Group 1.7709915388318567 ns/iter 1.694898179660882 ns/iter 1.04
Regex_Period_Plus 2.0725928181493494 ns/iter 2.1054609646761224 ns/iter 0.98
Regex_Period 2.0116006927017174 ns/iter 2.159344542769177 ns/iter 0.93
Regex_Caret_Period_Plus_Dollar 1.958537421852145 ns/iter 2.0020823116657884 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 1.9987997450888728 ns/iter 2.225401451980401 ns/iter 0.90
Regex_Caret_Period_Asterisk_Dollar 1.624398624822703 ns/iter 1.7861854657756169 ns/iter 0.91
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6802202398162553 ns/iter 1.6737101808159158 ns/iter 1.00
Regex_Caret_X_Hyphen 7.02258494785629 ns/iter 6.630473399527316 ns/iter 1.06
Regex_Period_Md_Dollar 71.2046473647033 ns/iter 72.12473806286219 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 6.023519125699695 ns/iter 6.215811336759792 ns/iter 0.97
Regex_Caret_Period_Range_Dollar 2.151320299519597 ns/iter 2.442503672773014 ns/iter 0.88
Regex_Nested_Backtrack 751.8222764931892 ns/iter 778.1836685264979 ns/iter 0.97
Pointer_Object_Traverse 15.011725648559045 ns/iter 15.889012852370337 ns/iter 0.94
Pointer_Object_Try_Traverse 33.87699145421808 ns/iter 33.4104883926905 ns/iter 1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer 192.94072538691674 ns/iter 183.63642202813023 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 5a370db Previous: 08ea8d9 Ratio
JSON_Array_Of_Objects_Unique 422.7403125000251 ns/iter 418.99474403936665 ns/iter 1.01
JSON_Parse_1 80947.39955358017 ns/iter 79744.63640015424 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 56.641000000001895 ns/iter 54.36856000000034 ns/iter 1.04
JSON_Equality_Helm_Chart_Lock 219.1939187860059 ns/iter 217.9135058967219 ns/iter 1.01
Regex_Lower_S_Or_Upper_S_Asterisk 8.156019606446813 ns/iter 8.165690588545985 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.9662629108640814 ns/iter 7.798883000898016 ns/iter 1.02
Regex_Period_Asterisk 8.052620535714539 ns/iter 7.785533482143693 ns/iter 1.03
Regex_Group_Period_Asterisk_Group 8.077529017857442 ns/iter 7.862993303571843 ns/iter 1.03
Regex_Period_Plus 7.79310264378155 ns/iter 7.837021840012947 ns/iter 0.99
Regex_Period 7.813049965119126 ns/iter 7.974022321428313 ns/iter 0.98
Regex_Caret_Period_Plus_Dollar 7.887980321929531 ns/iter 8.013027901786327 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 8.119813356607287 ns/iter 8.489150854958405 ns/iter 0.96
Regex_Caret_Period_Asterisk_Dollar 8.552028124999111 ns/iter 7.753978794643299 ns/iter 1.10
Regex_Caret_Group_Period_Asterisk_Group_Dollar 8.092919160300141 ns/iter 7.883224518378094 ns/iter 1.03
Regex_Caret_X_Hyphen 11.565073214285349 ns/iter 11.952732812499534 ns/iter 0.97
Regex_Period_Md_Dollar 142.3584177518558 ns/iter 143.64406250000985 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 11.717530357141673 ns/iter 11.67749062499901 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 8.883669603196568 ns/iter 8.943330763645985 ns/iter 0.99
Regex_Nested_Backtrack 595.5483928571782 ns/iter 587.8857142856677 ns/iter 1.01
Pointer_Object_Traverse 55.79824107142274 ns/iter 56.08248214285944 ns/iter 0.99
Pointer_Object_Try_Traverse 76.00024107143253 ns/iter 75.84008035713907 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 179.55700710329367 ns/iter 189.7341865834237 ns/iter 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 5a370db Previous: 08ea8d9 Ratio
Pointer_Object_Traverse 45.65428240357155 ns/iter 52.11801719840574 ns/iter 0.88
Pointer_Object_Try_Traverse 22.456897298379847 ns/iter 22.414314528018476 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.2162161914066 ns/iter 213.50259850350199 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.4860855756639526 ns/iter 2.4884240800170185 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4869167092782405 ns/iter 2.48587408908152 ns/iter 1.00
Regex_Period_Asterisk 2.487265397638093 ns/iter 2.488464289802073 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.4897838006230617 ns/iter 2.5487888335876563 ns/iter 0.98
Regex_Period_Plus 2.7965660268131303 ns/iter 2.4891424237451614 ns/iter 1.12
Regex_Period 2.7956622684702057 ns/iter 2.5059946916387283 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 2.710292061871898 ns/iter 2.486641705289204 ns/iter 1.09
Regex_Caret_Group_Period_Plus_Group_Dollar 2.48719509517875 ns/iter 2.4886072776807415 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 2.7975636224476284 ns/iter 2.796502317947934 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.798766982476104 ns/iter 2.799954662955765 ns/iter 1.00
Regex_Caret_X_Hyphen 12.431577358245443 ns/iter 13.053280698598012 ns/iter 0.95
Regex_Period_Md_Dollar 88.0625311724425 ns/iter 89.43861262849947 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 5.9336128370917445 ns/iter 7.146004550915311 ns/iter 0.83
Regex_Caret_Period_Range_Dollar 2.797208486570127 ns/iter 4.038257818128988 ns/iter 0.69
Regex_Nested_Backtrack 826.2833069186707 ns/iter 817.2460596747886 ns/iter 1.01
JSON_Array_Of_Objects_Unique 381.49787143924436 ns/iter 376.77039072668566 ns/iter 1.01
JSON_Parse_1 32743.50752849394 ns/iter 32592.001259854707 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 62.59160757879214 ns/iter 62.46220682271089 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 142.87890065529007 ns/iter 148.6278505563362 ns/iter 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 0073e1e into main Jan 7, 2025
13 checks passed
@jviotti jviotti deleted the flat-file-resolver-relative branch January 7, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant