-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider .json
as a fallback on FlatFileSchemaResolver
#1433
Conversation
Signed-off-by: Juan Cruz Viotti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 408d290 | Previous: 155f7df | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
407.1103796667322 ns/iter |
408.4482100158244 ns/iter |
1.00 |
JSON_Parse_1 |
29957.79628360884 ns/iter |
30333.23301393939 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.74192393762657 ns/iter |
58.8110535827465 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
143.92541277520482 ns/iter |
148.2249319402826 ns/iter |
0.97 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.1980297111081946 ns/iter |
2.198498162828946 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.209433789157055 ns/iter |
2.196283540813753 ns/iter |
1.01 |
Regex_Period_Asterisk |
2.2042728707977504 ns/iter |
2.2064521310490393 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.2118049693458888 ns/iter |
2.231542070357592 ns/iter |
0.99 |
Regex_Period_Plus |
2.815702754357114 ns/iter |
2.6107275633396094 ns/iter |
1.08 |
Regex_Period |
2.809196435193131 ns/iter |
2.4873920976325796 ns/iter |
1.13 |
Regex_Caret_Period_Plus_Dollar |
2.797537279506081 ns/iter |
2.7973911583959334 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.804118923332337 ns/iter |
2.4900368246054336 ns/iter |
1.13 |
Regex_Caret_Period_Asterisk_Dollar |
2.590315010954275 ns/iter |
2.798560861498247 ns/iter |
0.93 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.196682205911451 ns/iter |
2.4075829974685825 ns/iter |
0.91 |
Regex_Caret_X_Hyphen |
12.657554815909736 ns/iter |
13.05393968216463 ns/iter |
0.97 |
Regex_Period_Md_Dollar |
73.57937290789697 ns/iter |
73.71567415583506 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
5.598998220004444 ns/iter |
6.232593982640402 ns/iter |
0.90 |
Regex_Caret_Period_Range_Dollar |
2.798216848902081 ns/iter |
4.044093905079614 ns/iter |
0.69 |
Regex_Nested_Backtrack |
499.1038360833922 ns/iter |
505.8145589632831 ns/iter |
0.99 |
Pointer_Object_Traverse |
44.39187613689191 ns/iter |
44.26957748365515 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.63503643376888 ns/iter |
52.89318819359772 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
352.62794001093874 ns/iter |
352.3983709971994 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 408d290 | Previous: 155f7df | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
384.8534540511022 ns/iter |
362.2148494940453 ns/iter |
1.06 |
JSON_Parse_1 |
22951.112486509304 ns/iter |
26314.21519930551 ns/iter |
0.87 |
JSON_Fast_Hash_Helm_Chart_Lock |
51.61058283743687 ns/iter |
51.082345972693155 ns/iter |
1.01 |
JSON_Equality_Helm_Chart_Lock |
140.49160892045094 ns/iter |
132.56141446773168 ns/iter |
1.06 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.7127809464905468 ns/iter |
1.6933727503900786 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.074878004726731 ns/iter |
1.6959133103976967 ns/iter |
1.22 |
Regex_Period_Asterisk |
1.7063616957274217 ns/iter |
1.7340125969627047 ns/iter |
0.98 |
Regex_Group_Period_Asterisk_Group |
1.6927522229874143 ns/iter |
1.7715049882166007 ns/iter |
0.96 |
Regex_Period_Plus |
2.0325489837289337 ns/iter |
2.1206099350509544 ns/iter |
0.96 |
Regex_Period |
2.0244240676306124 ns/iter |
1.9478946156568901 ns/iter |
1.04 |
Regex_Caret_Period_Plus_Dollar |
2.021666254100833 ns/iter |
1.9009557687861836 ns/iter |
1.06 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.1088577019315364 ns/iter |
2.1295953624860724 ns/iter |
0.99 |
Regex_Caret_Period_Asterisk_Dollar |
1.778722408850317 ns/iter |
1.6260143025991027 ns/iter |
1.09 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.6850252411780304 ns/iter |
1.9670289572249953 ns/iter |
0.86 |
Regex_Caret_X_Hyphen |
6.877352797437029 ns/iter |
6.564409369610985 ns/iter |
1.05 |
Regex_Period_Md_Dollar |
72.65810686545804 ns/iter |
74.21061401541779 ns/iter |
0.98 |
Regex_Caret_Slash_Period_Asterisk |
6.241891646322514 ns/iter |
6.250786527160263 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
2.231651043181232 ns/iter |
2.213277152578898 ns/iter |
1.01 |
Regex_Nested_Backtrack |
785.9990678008508 ns/iter |
769.011992871782 ns/iter |
1.02 |
Pointer_Object_Traverse |
16.029678280570568 ns/iter |
15.225129237009703 ns/iter |
1.05 |
Pointer_Object_Try_Traverse |
33.80627128594625 ns/iter |
33.0785461614115 ns/iter |
1.02 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
192.3187270226907 ns/iter |
186.9152230483841 ns/iter |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 408d290 | Previous: 155f7df | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
421.13057696241725 ns/iter |
424.7703342274879 ns/iter |
0.99 |
JSON_Parse_1 |
81825.8593749986 ns/iter |
80477.7008928527 ns/iter |
1.02 |
JSON_Fast_Hash_Helm_Chart_Lock |
53.282419999993635 ns/iter |
55.052491071429756 ns/iter |
0.97 |
JSON_Equality_Helm_Chart_Lock |
220.87665625001307 ns/iter |
218.13830722596174 ns/iter |
1.01 |
Regex_Lower_S_Or_Upper_S_Asterisk |
8.162746651785925 ns/iter |
8.114278088774974 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.911014696825334 ns/iter |
7.945601750242581 ns/iter |
1.00 |
Regex_Period_Asterisk |
7.906025857563068 ns/iter |
8.0898267495994 ns/iter |
0.98 |
Regex_Group_Period_Asterisk_Group |
7.938468750000435 ns/iter |
7.83857407214998 ns/iter |
1.01 |
Regex_Period_Plus |
8.134476562499263 ns/iter |
8.213435267857403 ns/iter |
0.99 |
Regex_Period |
8.158549517148442 ns/iter |
7.892959786192015 ns/iter |
1.03 |
Regex_Caret_Period_Plus_Dollar |
8.251416927449219 ns/iter |
7.767992187500842 ns/iter |
1.06 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
8.16549505283276 ns/iter |
8.074195946098085 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
8.100342633927987 ns/iter |
7.87800111607189 ns/iter |
1.03 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
8.029814732142576 ns/iter |
7.886585937500865 ns/iter |
1.02 |
Regex_Caret_X_Hyphen |
11.791402179504082 ns/iter |
11.535653571428384 ns/iter |
1.02 |
Regex_Period_Md_Dollar |
143.03160968607875 ns/iter |
141.11794459296047 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
11.957466071430238 ns/iter |
11.694160714286893 ns/iter |
1.02 |
Regex_Caret_Period_Range_Dollar |
8.782368710793756 ns/iter |
8.693103979048367 ns/iter |
1.01 |
Regex_Nested_Backtrack |
599.125267857151 ns/iter |
593.8864285714171 ns/iter |
1.01 |
Pointer_Object_Traverse |
57.14129464286494 ns/iter |
56.073741071429595 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
76.38185267857216 ns/iter |
76.04782366071713 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
179.54029327279582 ns/iter |
204.6391136322095 ns/iter |
0.88 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 408d290 | Previous: 155f7df | Ratio |
---|---|---|---|
Pointer_Object_Traverse |
44.65884730090161 ns/iter |
43.7035637265842 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
22.495930777353593 ns/iter |
22.41587122421474 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
213.26506046116663 ns/iter |
213.3812547934447 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.4961250650591547 ns/iter |
3.1432561072064553 ns/iter |
0.79 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.49268449179302 ns/iter |
3.186530036848169 ns/iter |
0.78 |
Regex_Period_Asterisk |
2.489685934376574 ns/iter |
3.170743597734334 ns/iter |
0.79 |
Regex_Group_Period_Asterisk_Group |
2.4884092582242574 ns/iter |
3.1638082123029636 ns/iter |
0.79 |
Regex_Period_Plus |
2.7972456862234183 ns/iter |
3.2204335621556717 ns/iter |
0.87 |
Regex_Period |
2.799002426087522 ns/iter |
3.16464088672965 ns/iter |
0.88 |
Regex_Caret_Period_Plus_Dollar |
2.720650060438733 ns/iter |
3.368436487407463 ns/iter |
0.81 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.486509330308508 ns/iter |
3.2027970015366254 ns/iter |
0.78 |
Regex_Caret_Period_Asterisk_Dollar |
2.8004346921762022 ns/iter |
3.3346611847070338 ns/iter |
0.84 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.7980245967573447 ns/iter |
3.2009860852522922 ns/iter |
0.87 |
Regex_Caret_X_Hyphen |
13.24183770715226 ns/iter |
12.429884568680945 ns/iter |
1.07 |
Regex_Period_Md_Dollar |
87.79345445918008 ns/iter |
89.98304883619838 ns/iter |
0.98 |
Regex_Caret_Slash_Period_Asterisk |
7.148666252516989 ns/iter |
6.216569595074001 ns/iter |
1.15 |
Regex_Caret_Period_Range_Dollar |
4.039226816448722 ns/iter |
4.0392367100288595 ns/iter |
1.00 |
Regex_Nested_Backtrack |
809.1900044671119 ns/iter |
821.6237323064072 ns/iter |
0.98 |
JSON_Array_Of_Objects_Unique |
373.537341870822 ns/iter |
380.75705821127053 ns/iter |
0.98 |
JSON_Parse_1 |
32720.20526068473 ns/iter |
32916.4773017192 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.88207489601302 ns/iter |
62.79853360970092 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
145.5445033085248 ns/iter |
144.86650784090227 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]