Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume GoogleTest from Noa #1453

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Consume GoogleTest from Noa #1453

merged 1 commit into from
Jan 20, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 20, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 6c9718f Previous: 8b8cc12 Ratio
JSON_Array_Of_Objects_Unique 378.7527986365837 ns/iter 351.45677150675107 ns/iter 1.08
JSON_Parse_1 24243.010031217258 ns/iter 22773.928101807418 ns/iter 1.06
JSON_Fast_Hash_Helm_Chart_Lock 52.45030161383466 ns/iter 51.90065003780909 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 145.55675042356563 ns/iter 138.54008068441172 ns/iter 1.05
Regex_Lower_S_Or_Upper_S_Asterisk 1.556741681642279 ns/iter 1.6883148379794881 ns/iter 0.92
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.5695968689336333 ns/iter 1.7750759103973508 ns/iter 0.88
Regex_Period_Asterisk 1.4444423512513076 ns/iter 1.6732893518697933 ns/iter 0.86
Regex_Group_Period_Asterisk_Group 1.4821487764234302 ns/iter 1.7950499271115052 ns/iter 0.83
Regex_Period_Plus 1.7694424609295092 ns/iter 2.0041366280305652 ns/iter 0.88
Regex_Period 1.9552281895332497 ns/iter 2.0071737895910036 ns/iter 0.97
Regex_Caret_Period_Plus_Dollar 1.753557749419999 ns/iter 2.0021058484690406 ns/iter 0.88
Regex_Caret_Group_Period_Plus_Group_Dollar 1.8506237080367856 ns/iter 2.1098496363521826 ns/iter 0.88
Regex_Caret_Period_Asterisk_Dollar 1.5575960831347047 ns/iter 1.6739755224412882 ns/iter 0.93
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.4471804541432263 ns/iter 1.5993445989342063 ns/iter 0.90
Regex_Caret_X_Hyphen 6.398425103839317 ns/iter 6.385769605681454 ns/iter 1.00
Regex_Period_Md_Dollar 76.53079159325598 ns/iter 69.54390576195301 ns/iter 1.10
Regex_Caret_Slash_Period_Asterisk 7.575716133300779 ns/iter 5.938559317174512 ns/iter 1.28
Regex_Caret_Period_Range_Dollar 1.927512551298868 ns/iter 2.038054078310847 ns/iter 0.95
Regex_Nested_Backtrack 761.0447372837665 ns/iter 730.2330364581778 ns/iter 1.04
Pointer_Object_Traverse 29.377378646310312 ns/iter 15.55323480333421 ns/iter 1.89
Pointer_Object_Try_Traverse 45.57079062290895 ns/iter 33.749376745985295 ns/iter 1.35
Pointer_Push_Back_Pointer_To_Weak_Pointer 190.57020037717368 ns/iter 185.37158985972377 ns/iter 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 6c9718f Previous: 8b8cc12 Ratio
JSON_Array_Of_Objects_Unique 289.13907450805647 ns/iter 375.5811143631261 ns/iter 0.77
JSON_Parse_1 32809.30550088858 ns/iter 32997.56868014995 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 30.137997490869353 ns/iter 63.291847200138186 ns/iter 0.48
JSON_Equality_Helm_Chart_Lock 140.6843472903065 ns/iter 143.2050189172627 ns/iter 0.98
Regex_Lower_S_Or_Upper_S_Asterisk 3.1108613730080905 ns/iter 2.4870177327963128 ns/iter 1.25
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.1077181190241183 ns/iter 2.4892204994027813 ns/iter 1.25
Regex_Period_Asterisk 3.110417510481086 ns/iter 2.4870208259409656 ns/iter 1.25
Regex_Group_Period_Asterisk_Group 3.1088544626800463 ns/iter 2.4948229722122104 ns/iter 1.25
Regex_Period_Plus 3.4317752233559813 ns/iter 2.796173976079759 ns/iter 1.23
Regex_Period 3.419890730640624 ns/iter 2.802463205398919 ns/iter 1.22
Regex_Caret_Period_Plus_Dollar 3.4208594339229363 ns/iter 2.803789144435026 ns/iter 1.22
Regex_Caret_Group_Period_Plus_Group_Dollar 3.4332244771265525 ns/iter 2.7991547787112894 ns/iter 1.23
Regex_Caret_Period_Asterisk_Dollar 4.3496183335084515 ns/iter 3.7284778447389404 ns/iter 1.17
Regex_Caret_Group_Period_Asterisk_Group_Dollar 4.352543386100242 ns/iter 3.730048770547466 ns/iter 1.17
Regex_Caret_X_Hyphen 12.432598837377633 ns/iter 13.052135893196889 ns/iter 0.95
Regex_Period_Md_Dollar 101.79159192294573 ns/iter 87.89540772296026 ns/iter 1.16
Regex_Caret_Slash_Period_Asterisk 8.098019887719316 ns/iter 7.156904618105497 ns/iter 1.13
Regex_Caret_Period_Range_Dollar 4.3544009584828824 ns/iter 4.042976382681505 ns/iter 1.08
Regex_Nested_Backtrack 834.3972591628004 ns/iter 821.996244360124 ns/iter 1.02
Pointer_Object_Traverse 70.80141056244796 ns/iter 43.945121102072406 ns/iter 1.61
Pointer_Object_Try_Traverse 62.38157535427142 ns/iter 22.41031203236878 ns/iter 2.78
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.64359378371955 ns/iter 213.3003935823289 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 6c9718f Previous: 8b8cc12 Ratio
JSON_Array_Of_Objects_Unique 405.2765995857395 ns/iter 411.37790409371377 ns/iter 0.99
JSON_Parse_1 30210.450635637873 ns/iter 30000.7960390948 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 58.41861139726673 ns/iter 58.76273085643462 ns/iter 0.99
JSON_Equality_Helm_Chart_Lock 152.63583695623535 ns/iter 142.83312492551053 ns/iter 1.07
Regex_Lower_S_Or_Upper_S_Asterisk 2.189664436743485 ns/iter 2.1872788522895497 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.183787178705444 ns/iter 2.189393463692151 ns/iter 1.00
Regex_Period_Asterisk 2.185527933231983 ns/iter 2.1817443040501137 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.2053503151537948 ns/iter 2.1822365636953363 ns/iter 1.01
Regex_Period_Plus 2.7898694702799873 ns/iter 2.808314096968568 ns/iter 0.99
Regex_Period 2.7787309501869983 ns/iter 2.832936257038311 ns/iter 0.98
Regex_Caret_Period_Plus_Dollar 3.100786946001106 ns/iter 2.8031602600028354 ns/iter 1.11
Regex_Caret_Group_Period_Plus_Group_Dollar 2.788349426889452 ns/iter 2.556390018450607 ns/iter 1.09
Regex_Caret_Period_Asterisk_Dollar 3.5702900099021155 ns/iter 2.3242363099441614 ns/iter 1.54
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4128928276107864 ns/iter 2.1833176117237794 ns/iter 1.56
Regex_Caret_X_Hyphen 12.611977908978433 ns/iter 12.666524323595787 ns/iter 1.00
Regex_Period_Md_Dollar 74.31884931562293 ns/iter 73.63432745097082 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 6.839175192803821 ns/iter 5.592857447466033 ns/iter 1.22
Regex_Caret_Period_Range_Dollar 4.014104154749943 ns/iter 4.040680215827557 ns/iter 0.99
Regex_Nested_Backtrack 490.65978088460525 ns/iter 501.16589583013183 ns/iter 0.98
Pointer_Object_Traverse 44.40094376816379 ns/iter 44.465699368387504 ns/iter 1.00
Pointer_Object_Try_Traverse 52.21844875757034 ns/iter 52.5729544746937 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 351.90203803130345 ns/iter 352.05800191430626 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the noa-googletest branch 2 times, most recently from 039b446 to 93faa1d Compare January 20, 2025 16:46
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 6c9718f Previous: 8b8cc12 Ratio
JSON_Array_Of_Objects_Unique 419.7794316619115 ns/iter 417.65884650927444 ns/iter 1.01
JSON_Parse_1 80859.10714285153 ns/iter 81164.12946428398 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 57.20184821427666 ns/iter 54.31234000000131 ns/iter 1.05
JSON_Equality_Helm_Chart_Lock 216.75087500000245 ns/iter 217.54590625000958 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 8.448770051569166 ns/iter 8.112622731638814 ns/iter 1.04
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.798370054472878 ns/iter 8.26449999999923 ns/iter 0.94
Regex_Period_Asterisk 7.93532924107205 ns/iter 7.993792410714613 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 7.951499964503517 ns/iter 8.203787499997617 ns/iter 0.97
Regex_Period_Plus 7.7603463939273505 ns/iter 7.969154428707562 ns/iter 0.97
Regex_Period 7.884480768374795 ns/iter 8.006948660713878 ns/iter 0.98
Regex_Caret_Period_Plus_Dollar 7.783931919642027 ns/iter 8.175994419641341 ns/iter 0.95
Regex_Caret_Group_Period_Plus_Group_Dollar 8.414560267857903 ns/iter 8.202918713380043 ns/iter 1.03
Regex_Caret_Period_Asterisk_Dollar 7.965892857144346 ns/iter 8.209718749999492 ns/iter 0.97
Regex_Caret_Group_Period_Asterisk_Group_Dollar 8.160665178569916 ns/iter 7.963677455357247 ns/iter 1.02
Regex_Caret_X_Hyphen 11.600062500000215 ns/iter 11.573325000000523 ns/iter 1.00
Regex_Period_Md_Dollar 142.31100703969216 ns/iter 142.35646909125856 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 11.550753571429238 ns/iter 11.95545530376952 ns/iter 0.97
Regex_Caret_Period_Range_Dollar 8.683789062498448 ns/iter 8.794920496451379 ns/iter 0.99
Regex_Nested_Backtrack 593.4033035714492 ns/iter 590.0379464287247 ns/iter 1.01
Pointer_Object_Traverse 56.61851785715401 ns/iter 56.400857142863615 ns/iter 1.00
Pointer_Object_Try_Traverse 75.94284598214175 ns/iter 76.894252232153 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 187.0460256291015 ns/iter 183.46852530970042 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti jviotti marked this pull request as ready for review January 20, 2025 16:57
@jviotti jviotti merged commit b193b68 into main Jan 20, 2025
13 checks passed
@jviotti jviotti deleted the noa-googletest branch January 20, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant