Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uri): add setter for path #887

Merged
merged 34 commits into from
Aug 8, 2024
Merged

feat(uri): add setter for path #887

merged 34 commits into from
Aug 8, 2024

Conversation

tony-go
Copy link
Contributor

@tony-go tony-go commented Jul 31, 2024

Part of #811

src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
test/uri/uri_path_test.cc Show resolved Hide resolved
tony-go added 2 commits August 1, 2024 13:54
Signed-off-by: Tony Gorez <[email protected]>
Signed-off-by: Tony Gorez <[email protected]>
@tony-go tony-go requested a review from jviotti August 1, 2024 12:04
@jviotti
Copy link
Member

jviotti commented Aug 1, 2024

Not sure if here or in another PR, but as you implement setters or any new functionality in URI, it might be worth searching uses of URI in other modules, like jsonschema and see if they can be refactored to use the new functionality. I remember leaving lots of TODOs for improvements on URIs that we planned (though not sure if for path setters though)

@tony-go
Copy link
Contributor Author

tony-go commented Aug 2, 2024

Not sure if here or in another PR, but as you implement setters or any new functionality in URI, it might be worth searching uses of URI in other modules, like jsonschema and see if they can be refactored to use the new functionality. I remember leaving lots of TODOs for improvements on URIs that we planned (though not sure if for path setters though)

Yeah let me try :)

What I found so far is: https://github.com/sourcemeta/jsontoolkit/blob/main/src/jsonschema/reference.cc#L381

src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
test/uri/uri_path_test.cc Outdated Show resolved Hide resolved
@tony-go tony-go requested a review from jviotti August 5, 2024 11:54
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
test/uri/uri_path_test.cc Show resolved Hide resolved
@tony-go tony-go requested a review from jviotti August 5, 2024 16:46
src/uri/include/sourcemeta/jsontoolkit/uri.h Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
@tony-go tony-go requested a review from jviotti August 7, 2024 21:12
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
src/uri/uri.cc Outdated Show resolved Hide resolved
test/uri/uri_path_test.cc Outdated Show resolved Hide resolved
@tony-go tony-go merged commit b0dec14 into main Aug 8, 2024
12 checks passed
@tony-go tony-go deleted the add-path-setter branch August 8, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants