Lazy relations loaded via injected request

[thewebartisan7]

Supposely we have

    public static function fromModel(Model $model): self
    {
        return new self(
            relations: Lazy::whenLoaded('relations', $model, fn () => ModelData::collection($model->relations)),
            relationsCount: Lazy::create(fn () => $model->relations_count)
        );
    }

How to avoid loading relations when in query we have withCount('relations') ?

Because in my case it load also the relations when withCount('relations') is loaded.

[Nir-An]

Hi @thewebartisan7
what happens if you do something like :

relations: Lazy::whenLoaded('relations', $model, fn () => ModelData::collection($model->relations)),
relationsCount: Lazy::whenLoaded('relations', $model, fn () => $model->relations_count)

?

[thewebartisan7]

It's the same, because I check RelationLazy and behind the scene it's just check if relations is loaded, and in both case, relations_count and relations is marked as loaded:

    public function shouldBeIncluded(): bool
    {
        return $this->model->relationLoaded($this->relation);
    }

[Nir-An]

Hi @rubenvanassche
from the first view, I think the problem is here :
https://github.com/spatie/laravel-data/blob/main/src/Transformers/DataTransformer.php#L73

  if (! $this->shouldIncludeProperty($name, $data->{$name}, $trees)) {
                    return $payload;
  }

$data->{$name}

but I'm not sure, I'm going to test it

[rubenvanassche]

Could you provide me a test which reproduces the problem? Tried this by changing this test (which may be a good starting point):

laravel-data/tests/DataTest.php

Lines 290 to 303 in 782aced

	/** @test */
	public function it_can_include_data_based_upon_relations_loaded()
	{
	$model = FakeNestedModel::factory()->create();
	$transformed = FakeNestedModelData::createWithLazyWhenLoaded($model)->all();
	$this->assertArrayNotHasKey('fake_model', $transformed);
	$transformed = FakeNestedModelData::createWithLazyWhenLoaded($model->load('fakeModel'))->all();
	$this->assertArrayHasKey('fake_model', $transformed);
	$this->assertInstanceOf(FakeModelData::class, $transformed['fake_model']);
	}

But couldn't reproduce the issue

[thewebartisan7]

I will try to reproduce in a test, but not sure when get time.
This was just a test project that I was working on, and currently is only locally.
Give me a week or two.