Validation in controller not working as expected

[OgaBoss]

Please i am new to the package, I think i am doning somethings wrong, not just sure what.

Above i have a DTO class, a Service class or Action class and a controller.

I noticed that when i remove the ProfileCompletionDto $dto, in the controller invoke function, the function throws an InvalidArgumentException exception, but once i put it back it works fine and returns the validation error.

Do i really need to have the DTO in the arguments, even though it's not doing anything in the controller.

What am i doing wrong ?

Below is my code

<?php

namespace Domain\Authentication\DataTransferObject;

use Domain\Connections\DatTransferObject\InviteDTO;
use Spatie\LaravelData\Attributes\DataCollectionOf;
use Spatie\LaravelData\Attributes\MapInputName;
use Spatie\LaravelData\Attributes\Validation\StringType;
use Spatie\LaravelData\Attributes\Validation\Unique;
use Spatie\LaravelData\Data;
use Spatie\LaravelData\DataCollection;
use Symfony\Contracts\Service\Attribute\Required;

class ProfileCompletionDto extends Data
{
	#[MapInputName('first_name')]
	#[Required]
	#[StringType]
	public string $firstName;

	#[MapInputName('last_name')]
	#[Required]
	#[StringType]
	public string $lastName;

	#[Required]
	#[StringType]
	public string $gender;

	#[Required]
	#[StringType]
	public string $country;

	#[Required]
	#[StringType]
	#[MapInputName('phone_code')]
	public string $phoneCode;

	#[Required]
	#[StringType]
	#[Unique('users')]
	public string $phone;

	#[Required]
	#[StringType]
	public string $dob;

	#[Required]
	#[StringType]
	#[MapInputName('about_me')]
	public string $aboutMe;

	#[DataCollectionOf(InviteDTO::class)]
	public DataCollection $invites;

	public static function stopOnFirstFailure(): bool
	{
		return true;
	}
}

<?php

namespace Domain\Authentication\Actions;

use Carbon\Carbon;
use Domain\Authentication\DataTransferObject\ProfileCompletionDto;
use Domain\Authentication\Models\User;
use Domain\Connections\Actions\CreateInvitationAction;
use Spatie\LaravelData\Contracts\DataObject;

class ProfileCompletionAction
{
	public CreateInvitationAction $invitationAction;

	/**
	 * @param CreateInvitationAction $invitationAction
	 */
	public function __construct(CreateInvitationAction $invitationAction)
	{
		$this->invitationAction = $invitationAction;
	}

	/** @var ProfileCompletionDto $dto
	 *  @var User $user
	 */
	public function __invoke(DataObject $dto, User $user): void
	{
		// Update User Details
		$user->first_name = $dto->firstName;
		$user->last_name = $dto->lastName;
		$user->gender = $dto->gender;
		$user->country = $dto->country;
		$user->phone_code = $dto->phoneCode;
		$user->dob = $dto->dob;
		$user->phone = $dto->phone;
		$user->about_me = $dto->aboutMe;
		$user->profile_completed_at = Carbon::now()->format('Y-m-d H:i:s');

		$user->save();

		$this->invitationAction->execute($dto->invites, $user);
	}
}

<?php

namespace App\Authentication\Controllers;

use App\Authentication\Requests\ProfileCompletionRequest;
use Domain\Authentication\Actions\ProfileCompletionAction;
use Domain\Authentication\DataTransferObject\ProfileCompletionDto;
use Illuminate\Http\JsonResponse;

class ProfileCompletionController
{
	public function __invoke(
		ProfileCompletionRequest $request,
		ProfileCompletionDto $dto,
		ProfileCompletionAction $action
	): JsonResponse {
		try
		{
			$action($request->getData(), $request->user());

			return response()->json(['data' => [], 'status' => trans('basic.success')], 200);
		}
		catch (\Throwable $exception)
		{
			return response()->json(['status' => trans('basic.success'),
				'message'                        => $exception->getMessage(), ], $exception->getCode());
		}
	}
}

[rubenvanassche]

Why don't you replace this line:

$action($request->getData(), $request->user());

with this :

$action(dto);

?