Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for storing properties of type Double #274

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Add support for storing properties of type Double #274

merged 9 commits into from
Jan 31, 2025

Conversation

goneall
Copy link
Member

@goneall goneall commented Jan 7, 2025

This update depends on new versions of the SPDX core library (1.0.0-RC2 or later) and the SPDX 3 Model (1.0.0-RC2 or later)

Fixes #273

@goneall
Copy link
Member Author

goneall commented Jan 9, 2025

Also fixes #275

@bact bact linked an issue Jan 10, 2025 that may be closed by this pull request
Converting SPDX 2 to 3 generates incorrect namespace #275
Closed
pmonks
pmonks approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@pmonks pmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't completely understand the problem, having not worked with SPDX models to date, but with that said the code changes themselves, in isolation, appear to me to be entirely reasonable and consistent with neighbouring code.

@goneall
Copy link
Member Author

goneall commented Jan 21, 2025

I don't completely understand the problem, having not worked with SPDX models to date, but with that said the code changes themselves, in isolation, appear to me to be entirely reasonable and consistent with neighbouring code.

Sorry @pmonks - I made the comment in the wrong tab, can you comment on issue #237 - thanks

@pmonks
Copy link
Collaborator

pmonks commented Jan 21, 2025

@goneall done! And no worries - this code change seemed small enough that I didn't mind giving it an uninformed once-over. 😉

@goneall goneall mentioned this pull request Jan 29, 2025
Closed
11 tasks
goneall and others added 9 commits January 29, 2025 18:03
@goneall
Rename IdentifierType.Unkown to IdentifierType.Unknown
5bb5549
@goneall
Add check for deprecated unkown ID type
c80581c 
Required for compatibility in case the deprecated field is still in use
@goneall
Rename DefaultStoreNotInitialized Exception
d96f283
@goneall
Add support for storing properties of type Double
49dc0c4 
This update depends on new versions of the SPDX core library (1.0.0-RC2
or later) and the SPDX 3 Model (1.0.0-RC2 or later)

Fixes #273
@goneall
Append '#' to document namespace when converting form 2
2c40596 
Fixes #275
@goneall @bact
Update src/main/java/org/spdx/storage/simple/InMemSpdxStore.java
f4b897e 
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
@goneall
additional logging for licenses
c930b02
@goneall
Merge branch 'renameunknown' into issue273
f22e75d
@goneall
Fix unit test failures
c6e568a
@goneall goneall marked this pull request as ready for review January 31, 2025 22:29
@goneall goneall merged commit e2cb4b9 into master Jan 31, 2025
1 check passed
@goneall goneall deleted the issue273 branch January 31, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bact bact bact left review comments

@pmonks pmonks pmonks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converting SPDX 2 to 3 generates incorrect namespace Support double types in model store
3 participants
@goneall @pmonks @bact