Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IModelStore.IdType.Unkown should be IModelStore.IdType.Unknown #19

Open
dwalluck opened this issue Jan 22, 2025 · 3 comments
Open

IModelStore.IdType.Unkown should be IModelStore.IdType.Unknown #19

dwalluck opened this issue Jan 22, 2025 · 3 comments

Comments

@dwalluck
Copy link
Contributor

No description provided.

@goneall
Copy link
Member

goneall commented Jan 22, 2025

Thanks @dwalluck - I need a better spell checker for the code!

@bact
Copy link
Collaborator

bact commented Jan 22, 2025

The renaming of the enum can be complicated

See #8 and spdx/Spdx-Java-Library#266 (comment)

@dwalluck
Copy link
Contributor Author

We can keep the old one and mark it as deprecated as we have done with the methods.

In fact, changing (removing) this will break the Library code, but the Library code can be changed afterwards if the old one is kept in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bact @goneall @dwalluck