Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External document reference without a space between the hash and hashvalue fails #11

Closed
goneall opened this issue May 2, 2021 · 2 comments

Comments

@goneall
Copy link
Member

goneall commented May 2, 2021

External document references include a SHA1:[value]. Currently, the tag/value parser expects a space after the colon and before the value.

Per the spec, this space is not required.

Note that the regex pattern that needs to change is here:

private static Pattern EXTERNAL_DOC_REF_PATTERN = Pattern.compile("(\\S+)\\s+(\\S+)\\s+SHA1:\\s+(\\S+)");

@goneall
Copy link
Member Author

goneall commented May 2, 2021

This is related to the issue swinslow/cmake-spdx#8

goneall added a commit that referenced this issue Jun 19, 2021
goneall added a commit that referenced this issue Jun 19, 2021
Resolve issue #11 - allow no spaces in exteral doc ref
@goneall
Copy link
Member Author

goneall commented Jul 10, 2021

Resolved with PR #15

@goneall goneall closed this as completed Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant