Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External document references not used with JSON formatted dependencies #140

Open
goneall opened this issue Nov 5, 2023 · 4 comments
Open
Assignees

Comments

@goneall
Copy link
Member

goneall commented Nov 5, 2023

External document references are used for dependencies which have SPDX document as a repository artifact.

XML formatted documents are included. However, .json files are not. This is likely due to how the plugin looks for and finds the dependencies.

@abhishekdumaniya
Copy link

Sir @goneall, I am interested in solving this issue, I want to work on it.

@goneall
Copy link
Member Author

goneall commented Dec 22, 2023

@MazeJack - that would be great. Let me know if you need any help understanding the code.

@abhishekdumaniya
Copy link

abhishekdumaniya commented Dec 23, 2023

sir @goneall,
I am a new member and would like to contribute to this issue. I came across a file named json-pom-use-artifact.xml. Could you please explain to me which dependencies are included in this .xml file and not in a .json file? do I have to rewrite code in the license.json file or any other .json file?

P.S. I found an externalReferences tag in json-pom-use-artifact.xml. Do I have to rewrite it in license.json or any other .json?

@goneall
Copy link
Member Author

goneall commented Dec 24, 2023

@MazeJack -The Java code that generates the external relationships will probably need to be modified.

The source file SpdxDependencyInformation is responsible for creating the external document references. Here's a link to the method that creates it:

private SpdxElement createExternalSpdxPackageReference( SpdxDocument externalSpdxDoc,

I would suggest looking for where this method is called and see if it is only looking for XML files and whether it can also search for JSON files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants