Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify type for the string literals defined in the individuals #164

Closed
goneall opened this issue Dec 7, 2024 · 2 comments · Fixed by #169
Closed

Specify type for the string literals defined in the individuals #164

goneall opened this issue Dec 7, 2024 · 2 comments · Fixed by #169
Assignees

Comments

@goneall
Copy link
Member

goneall commented Dec 7, 2024

Pyshacl is failing validation due to the type not being xsd:string for the comment fields defined in the creationInfo individuals.

For example:

ns1:comment "This individual element was defined by the spec."@en ;

should be changed to:

ns1:comment "This individual element was defined by the spec."^^xsd:string ;

Reference spdx/spdx-3-model#936 (comment).

@zvr zvr self-assigned this Dec 9, 2024
@zvr
Copy link
Member

zvr commented Dec 9, 2024

Grrr... stupid typo, instead of it being rdfs:comment it's a ns1:comment (so in SPDX namespace).
I'll fix it.

@bact
Copy link
Contributor

bact commented Dec 9, 2024

Warn that "ns1" "ns2" etc namespaces are up to rdflib to decided and this order could be changed if the code is updated (for example, we refactor the code or we have new profile).

Maybe in the next version (3.1?), we may like to suggest a namespace for each of the Profile and use than in RDF generation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants