Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test and CI #167

Open
goneall opened this issue Dec 9, 2024 · 1 comment
Open

Add unit test and CI #167

goneall opened this issue Dec 9, 2024 · 1 comment

Comments

@goneall
Copy link
Member

goneall commented Dec 9, 2024

After reviewing the issues caught in the spdx-spec CI runs of PySHACL, we could greatly shorting the error discovery time if we run something similar as a CI in the spec-parser itself.

The quickest implementation would be to basically copy the validation portions of the CI and create a test target with the example file being tested in the spec-parser.

A better implementation would be to have a richer example file with all properties, profiles and fields present (similar to the example files in the SPDX 2 version of spec).

A middle ground would be to translate the SPDX 2 example to SPDX 3.

@goneall
Copy link
Member Author

goneall commented Dec 9, 2024

@zvr I can create a PR for this with the simple approach if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant