Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize changes hex pattern order globally #94

Open
JoshuaStorm opened this issue Sep 16, 2017 · 6 comments
Open

Randomize changes hex pattern order globally #94

JoshuaStorm opened this issue Sep 16, 2017 · 6 comments
Labels

Comments

@JoshuaStorm
Copy link
Collaborator

The "randomize all" button seems to change the pattern globally, which I don't think we intend to?

@spiricom
Copy link
Owner

as in it changes it for both sequences?

@JoshuaStorm
Copy link
Collaborator Author

Oh, hmm I didn't actually check that...
I'll explain this in person sometime, hard to describe

@mulshine
Copy link
Collaborator

mulshine commented Sep 18, 2017 via email

@spiricom
Copy link
Owner

The behavior may be as intended, but not what you expect:
We're currently imagining there as being a "working sequence", and then the stored sequences in the composition view.
The randomize and clear buttons operate on the "working sequence". Is that what was confusing?

@JoshuaStorm
Copy link
Collaborator Author

JoshuaStorm commented Sep 18, 2017

Nah, that seems pretty natural.

Maybe this example makes more sense:

  1. I have a handful of saved sequences, 1-n
  2. I set working sequence to sequence 1
  3. I hit full-randomize button, this seems to result in change pattern order which is fine.
  4. I switch to another sequence, 2, I expect it to be exactly as I had saved sequence 2, but the changed pattern order persists.

This still might be intended, but I kind of like the ability to return completely to whatever saved state including the pattern order.

@spiricom
Copy link
Owner

yes, you are right, that's a bug. Must be that we don't save pattern order as part of the sequence, or don't retrieve it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants