Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate lack of apiVersion and kind when creating package to upload #2561

Open
markpollack opened this issue Nov 8, 2018 · 2 comments
Open

Investigate lack of apiVersion and kind when creating package to upload #2561

markpollack opened this issue Nov 8, 2018 · 2 comments
Labels
type/help-needed Calling help type/technical-debt Techical Dept

Comments

@markpollack
Copy link
Contributor

In SkipperStreamDeployer.createDependentPackage
why are there not entries for

apiVersion: skipper.spring.io/v1
kind: SpringCloudDeployerApplication

Which are required fields when skipper reads the package using SpringCloudDeployerApplicationManifestReader
@markpollack markpollack added this to the 2.0.0.M1 milestone Nov 8, 2018
@markpollack
Copy link
Contributor Author

Depending on the outcome, change the implementation of parseSpec method in StreamControllerTests to use the above mentioned reader.

@sabbyanandan sabbyanandan added the type/spike For spike label Nov 13, 2018
@sabbyanandan sabbyanandan modified the milestones: 2.0.0.M1, 2.0.0.RC1 Nov 27, 2018
@sabbyanandan
Copy link
Contributor

sabbyanandan commented Feb 7, 2019 •
edited
Loading

Depends on spring-cloud/spring-cloud-skipper#798.

@sabbyanandan sabbyanandan modified the milestones: 2.0.0.RC1, 2.1.0.M1 Feb 14, 2019
@sabbyanandan sabbyanandan modified the milestones: 2.1.0.M1, 2.2.0.M1 Mar 22, 2019
@sabbyanandan sabbyanandan removed this from the 2.3.0.M1 milestone Oct 21, 2019
@ilayaperumalg ilayaperumalg added the type/help-needed Calling help label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/help-needed Calling help type/technical-debt Techical Dept
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ilayaperumalg @markpollack @sabbyanandan