Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify batch error handling tests #1005

Open
2 tasks
onobc opened this issue Jan 18, 2025 · 0 comments
Open
2 tasks

Simplify batch error handling tests #1005

onobc opened this issue Jan 18, 2025 · 0 comments
Labels
theme: testing Issues related to testing type: improvement An improvement of implementation of existing feature

Comments

@onobc
Copy link
Collaborator

onobc commented Jan 18, 2025

Refactor batch error handling tests in DefaultPulsarConsumerErrorHandlerTests.

  • tests are 98% identical (fix that)
  • make it more clear the magic numbers expected during verification

Tip

Use the recently added whenBatchRecordListenerOneMessageBatchFailsThenSentToDltProperly as a template and make it re-usable.

Originally motivation in #1002 (comment)
@onobc onobc added theme: testing Issues related to testing type: improvement An improvement of implementation of existing feature labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: testing Issues related to testing type: improvement An improvement of implementation of existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onobc