Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: CRC handling in WaveformDataPacket #2

Open
watsonjj opened this issue Jan 14, 2020 · 1 comment
Open

TODO: CRC handling in WaveformDataPacket #2

watsonjj opened this issue Jan 14, 2020 · 1 comment

Comments

@watsonjj
Copy link
Contributor

In TargetDriver the CRC was unused and related code was commented out. We should make sure we at least restore the ability to perform the CRC, and discuss when this should be performed.
@watsonjj watsonjj changed the title TODO: CRC handling TODO: CRC handling in WaveformDataPacket Jan 14, 2020
@akira-okumura
Copy link

Agree.

This sort of ad-hoc comment/uncomment modifications were very frequently done in the old code. We should carefully discuss what functionality we have to implement and how it is tested before implementing the code. Test first.

@watsonjj watsonjj transferred this issue from sstcam/sstcam-base Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akira-okumura @watsonjj