Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader formatting #42

Open
hughsk opened this issue Oct 30, 2014 · 1 comment
Open

Shader formatting #42

hughsk opened this issue Oct 30, 2014 · 1 comment

Comments

@hughsk
Copy link
Member

hughsk commented Oct 30, 2014

The escaped-newline approach is simple, but not ideal considering that esprima removes the newlines on parsing which in turn will break any shaders with a #define directive. I think it'd be better to have these using either the [].join('\n') method or (preferably) load them in with brfs. Happy to make the changes, but @mikolalysenko would you be OK with this?

@mikolalysenko
Copy link
Member

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants