Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for @stdlib/stats/base/dists/signrank/quantile #4734

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

feat: add C implementation for @stdlib/stats/base/dists/signrank/quantile #4734

wants to merge 28 commits into from
+4,694 −600

Conversation

jalajk3004
Copy link

@jalajk3004 jalajk3004 commented Jan 13, 2025 •
edited
Loading

Resolves

#3885

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the Quantile for a signrank distribution.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the Quantile for a Signrank distribution in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@jalajk3004
adding c implementaion in readme.md
db060f5 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004
Added a benchmark file
9d4bc06 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: failed
---
@jalajk3004
feat:add c implementation example file
10daf8c 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: failed
---
@jalajk3004
feat:add the C src files
bb39038 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004
changes in package.json
f3d811f 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004
feat:added test files
b826bd5 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: failed
---
@jalajk3004
feat:added test files
8b0152b 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: failed
---
@jalajk3004
feat:added test files
2e3d912 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: failed
---
@jalajk3004
feat:added test files
7b865ea 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: failed
---
@jalajk3004
feat:added test files
eb33638 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: failed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 13, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot and others added 16 commits January 14, 2025 18:07
@stdlib-bot @jalajk3004
docs: update related packages sections
66cb237 
PR-URL: stdlib-js#4728
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@stdlib-bot @jalajk3004
docs: update namespace TypeScript declaration comments
b157d1c 
PR-URL: stdlib-js#4729
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@aayush0325 @jalajk3004
fix: add math/base/speical/abs in manifest.json of `blas/ext/base/d…
9ccf049 
…apxsumkbn`

PR-URL: stdlib-js#4732

Reviewed-by: Philipp Burckhardt <[email protected]>
@aayush0325 @jalajk3004
docs: update examples of stats/base/dmin
fefd435 
PR-URL: stdlib-js#4713

Reviewed-by: Philipp Burckhardt <[email protected]>
@aayush0325 @jalajk3004
feat: add C ndarray interface and refactor implementation for `stats/…
4dec3dd 
…base/dmeankbn2`

PR-URL: stdlib-js#4715

Reviewed-by: Philipp Burckhardt <[email protected]>
@headlessNode @jalajk3004
refactor: update blas/ext/base/dapx to follow current project conve…
f742e64 
…ntions

PR-URL: stdlib-js#4737

Reviewed-by: Philipp Burckhardt <[email protected]>
@stdlib-bot @jalajk3004
docs: update related packages sections
93ba64e 
PR-URL: stdlib-js#4739

Reviewed-by: Philipp Burckhardt <[email protected]>
@0PrashantYadav0 @Planeshifter @jalajk3004
feat: add C implementation for stats/base/dists/geometric/skewness
d558d5f 
PR-URL: stdlib-js#4093
Closes: stdlib-js#3641

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@stdlib-bot @jalajk3004
docs: update REPL namespace documentation
14c1188 
PR-URL: stdlib-js#4741
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@stdlib-bot @jalajk3004
docs: update namespace table of contents
774fae5 
PR-URL: stdlib-js#4742
Reviewed-by: Athan Reines <[email protected]>
@stdlib-bot @jalajk3004
docs: update namespace TypeScript declarations
cc0e85c 
PR-URL: stdlib-js#4740
Reviewed-by: Athan Reines <[email protected]>
@anandkaranubc @jalajk3004
bench: refactor random number generation in stats/base/dists/arcsine
d4fa726 
PR-URL: stdlib-js#4744
Reviewed-by: Athan Reines <[email protected]>
@Neerajpathak07 @kgryte
@stdlib-bot @jalajk3004
feat: add C implementation for number/float32/base/signbit
ebc9e35 
PR-URL: stdlib-js#3399
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@headlessNode @kgryte @jalajk3004
feat: add C ndarray API and refactor blas/ext/base/sapxsumors
8c49027 
PR-URL: stdlib-js#4746
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@jalajk3004
refactoring C implementation
307f740 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: failed
---
@jalajk3004
fix: edit the header file
320feda 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: failed
---
@jalajk3004 jalajk3004 mentioned this pull request Jan 14, 2025
Open
3 tasks
@jalajk3004
Copy link
Author

@anandkaranubc I hope this message finds you well. I kindly request your review of my PR #4734. If you find any issues or areas for improvement, please let me know. I am more than happy to make the necessary changes. I really want my PR to get merged

Thank you for your time and guidance!

@anandkaranubc
Copy link
Contributor

anandkaranubc commented Jan 15, 2025 •
edited
Loading

Hi @jalajk3004, it seems your PR includes unrelated changes from the stdlib repo, likely introduced when you updated your branch with new changes from develop. To fix this, rebase your branch onto the latest develop to exclude unrelated changes and confirm that only relevant files are included in the PR. After rebasing, review the changes and push (might have to force-push) the updated branch to clean up the PR.

Let me know when you are done with this and I will revisit the PR again :)

@jalajk3004
fix:refactor c implementation
95ca0d5 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
@jalajk3004
fix
29fa8b9 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004
Copy link
Author

jalajk3004 commented Jan 15, 2025 •
edited
Loading

@anandkaranubc I have followed your instruction, Rebase my branch quantile onto the latest develop branch to exclude unrelated changes and confirm that only relevant files are included in the PR. and did the force-push.
But still there are errors. Kindly look into it and guide me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jalajk3004 @stdlib-bot @anandkaranubc @aayush0325 @headlessNode @0PrashantYadav0 @Neerajpathak07