Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Unable to pass Fortran linter #4755

Open
2 tasks done
rreusser opened this issue Jan 14, 2025 · 0 comments
Open
2 tasks done

[BUG]: Unable to pass Fortran linter #4755

rreusser opened this issue Jan 14, 2025 · 0 comments
Labels
Bug Something isn't working. Tools Issue or pull request related to project tooling.

Comments

@rreusser
Copy link
Member

rreusser commented Jan 14, 2025

Description

I am unable to get Fortran files to pass the linter. It complains "No final newline expected" whether or not there is a final newline. I have been locally removing insert_final_newline from Fortran editorconfig to get things to pass, but this only gets is passing locally and not on CI. See:

https://github.com/rreusser/stdlib/blob/f257760db466ba38810e4fbb9fde4826e21f64ee/.editorconfig#L85-L89

Related Issues

No.

Questions

No.

Demo

No response

Reproduction

Run the linter on a project file:


$ make lint-editorconfig-files FILES="lib/node_modules/@stdlib/blas/base/dscal/src/dscal.f"
Linting files for basic formatting errors...
lib/node_modules/@stdlib/blas/base/dscal/src/dscal.f:
	No final newline expected

1 errors found
make: *** [lint-editorconfig-files] Error 1

A screenshot of cat lib/node_modules/@stdlib/blas/base/dscal/src/dscal.f:

Image

The issue persists whether or not I add a newline. Maybe it's one of those Windows crlf things?

Expected Results

I expect the linter to pass since the file has no trailing newline.

Actual Results

Linter fails due to expecting no final newline.

Version

current develop

Environments

N/A

Browser Version

N/A

Node.js / npm Version

[email protected] / [email protected]

Platform

Mac OS 15.2

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@kgryte kgryte changed the title [BUG] Unable to pass Fortran linter [BUG]: Unable to pass Fortran linter Jan 15, 2025
@kgryte kgryte added Bug Something isn't working. Tools Issue or pull request related to project tooling. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Tools Issue or pull request related to project tooling.
Projects
None yet
Development

No branches or pull requests

2 participants