Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: fix styling of verison select (cross-platform) #34

Open
2 tasks done
kgryte opened this issue Sep 11, 2021 · 1 comment
Open
2 tasks done

[Bug]: fix styling of verison select (cross-platform) #34

kgryte opened this issue Sep 11, 2021 · 1 comment
Labels

Comments

@kgryte
Copy link
Member

kgryte commented Sep 11, 2021

Description

Encountered a bug when viewing the API documentation on an iOS device where the styling of the version <select> element was incorrect.

Could consider a common approach to style a wrapper underneath the <select> element and thus allowing a custom (and consistent) arrow across devices.

Because we'd still be using the <select> element to display options, we'd retain web accessibility, while also ensuring that the <select> element has similar styling irrespective of view context.

Related Issues

No.

Questions

No.

Demo

N/A

Reproduction

- view API docs on an iOS device and attempt to use the side menu version filter.

Expected Results

Consistent styling.

Actual Results

Inconsistent styling.

Environments

N/A

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@kgryte kgryte added the bug label Sep 11, 2021
@kgryte
Copy link
Member Author

kgryte commented May 19, 2022

In the settings menu, we use the custom select technique described above. Could use it for reference.

<div className="settings-select-wrapper">
<select
className="settings-select"
onChange={ this._onThemeChange }
>
<option value="light">Light</option>
<option value="dark">Dark</option>
</select>
<div className="settings-select-custom">
<ChevronDownIcon className="settings-select-custom-icon"/>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant